feat: add concernedToName option for job execution in BackendsService

- Introduced a new `concernedToName` property in the ExecuteJobOptions interface to enhance job execution context.
- Updated BackendsService to utilize `concernedToName` for improved identity handling during job creation.
- Enhanced error handling in LifecycleHooksService to ensure robust processing of identity lifecycle updates.

Author: tacxou

apps/api/src/core/backends/_interfaces/execute-job-options.interface.ts

@@ -10,6 +10,7 @@ export interface ExecuteJobOptions {
   updateStatus?: boolean;
   switchToProcessing?: boolean;
   comment?: string;
+  concernedToName?: string;
   targetState?: any;
   dataState?: any;
   task?: Types.ObjectId;

apps/api/src/core/backends/backends.service.ts

@@ -298,6 +298,7 @@ export class BackendsService extends AbstractQueueProcessor {
           ...options,
           updateStatus: true,
           task: task._id as unknown as Types.ObjectId,
+          concernedToName: identity.identity.inetOrgPerson?.cn,
         },
       );
       result[identity.identity._id] = executedJob;
@@ -530,8 +531,20 @@ export class BackendsService extends AbstractQueueProcessor {
     let jobStore: Document<Jobs> = null;
     const disableLogs = options?.disableLogs === true;
     if (!disableLogs || !!concernedTo) {
-      const identity =
-        !disableLogs && concernedTo ? await this.identitiesService.findById<Identities>(concernedTo) : null;
+      let concernedToName = options?.concernedToName;
+      if (!concernedToName && !disableLogs && concernedTo) {
+        concernedToName =
+          payload?.after?.inetOrgPerson?.cn ??
+          payload?.identity?.inetOrgPerson?.cn ??
+          payload?.inetOrgPerson?.cn;
+      }
+      if (!concernedToName && !disableLogs && concernedTo) {
+        const identity = await this.identitiesService.model
+          .findById(concernedTo)
+          .select('inetOrgPerson.cn')
+          .lean();
+        concernedToName = identity?.inetOrgPerson?.cn;
+      }
       jobStore = await this.jobsService.create<Jobs>({
         jobId: job.id,
         action: actionType,
@@ -540,7 +553,7 @@ export class BackendsService extends AbstractQueueProcessor {
           ? {
               $ref: 'identities',
               id: concernedTo,
-              name: identity?.inetOrgPerson?.cn,
+              name: concernedToName,
             }
           : null,
         comment: options?.comment,

apps/api/src/management/lifecycle/lifecycle-hooks.service.ts

@@ -333,21 +333,25 @@ export class LifecycleHooksService extends AbstractLifecycleService {
             this.logger.verbose(`identities process request`, JSON.stringify(req, null, 2));
 
             for (const identity of identities) {
-              const hasMutation = hasLifecycleMutation(resolvedMutation);
-              const updated = await this.identitiesService.model.findOneAndUpdate(
-                { _id: identity._id },
-                {
-                  $set: {
-                    ...resolvedMutation,
-                    lifecycle: idRule.target,
-                    lastLifecycleUpdate: new Date(),
-                    ...(hasMutation ? { state: IdentityState.TO_SYNC } : {}),
+              try {
+                const hasMutation = hasLifecycleMutation(resolvedMutation);
+                const updated = await this.identitiesService.model.findOneAndUpdate(
+                  { _id: identity._id },
+                  {
+                    $set: {
+                      ...resolvedMutation,
+                      lifecycle: idRule.target,
+                      lastLifecycleUpdate: new Date(),
+                      ...(hasMutation ? { state: IdentityState.TO_SYNC } : {}),
+                    },
                   },
-                },
-                { new: true },
-              );
+                  { new: true },
+                );
+
+                if (!updated) {
+                  continue;
+                }
 
-              if (updated) {
                 await this.create({
                   refId: identity._id,
                   lifecycle: idRule.target,
@@ -357,13 +361,23 @@ export class LifecycleHooksService extends AbstractLifecycleService {
                 if (hasMutation) {
                   await this.backendsService.lifecycleChangedIdentities(
                     [{ id: updated._id.toString(), before: identity, after: updated }],
-                    { targetState: IdentityState.TO_SYNC },
+                    {
+                      async: true,
+                      updateStatus: false,
+                      targetState: IdentityState.TO_SYNC,
+                    },
                   );
                 }
 
                 this.logger.log(
                   `Identity <${identity._id}> updated to lifecycle <${idRule.target}> by trigger from source <${idRule.sources}>`,
                 );
+              } catch (error) {
+                this.logger.error(
+                  `Error processing identity <${identity._id}> for lifecycle trigger in source <${idRule.sources}>:`,
+                  error?.message,
+                  error?.stack,
+                );
               }
             }
           } catch (error) {

apps/web/src/pages/settings/cron.vue

@@ -55,18 +55,18 @@
           @click='toggleCronEnabled(row)'
         )
           q-tooltip.text-body2 {{ row.enabled ? 'Désactiver' : 'Activer' }} la tâche
-        //- q-btn(
-        //-   :disable='!hasPermission("/core/cron", "update")'
-        //-   :loading='!!cronRunLoading[row.name]'
-        //-   color='purple'
-        //-   icon='mdi-play-circle-outline'
-        //-   size='12px'
-        //-   flat
-        //-   round
-        //-   dense
-        //-   @click='runCronImmediately(row)'
-        //- )
-        //-   q-tooltip.text-body2 Exécuter immédiatement
+        q-btn(
+          :disable='!hasPermission("/core/cron", "update")'
+          :loading='!!cronRunLoading[row.name]'
+          color='purple'
+          icon='mdi-play-circle-outline'
+          size='12px'
+          flat
+          round
+          dense
+          @click='runCronImmediately(row)'
+        )
+          q-tooltip.text-body2 Exécuter immédiatement
         q-btn(
           :disable='!hasPermission("/core/cron", "read")'
           color='primary'