create user object and user endpoint#10
Open
xurror wants to merge 1 commit into
Open
Conversation
Author
|
@maektwain please can you have a look at this. |
maektwain
reviewed
May 16, 2020
maektwain
left a comment
maektwain
left a comment
There was a problem hiding this comment.
We could add the user in top level object
maektwain
approved these changes
May 16, 2020
maektwain
left a comment
maektwain
left a comment
There was a problem hiding this comment.
This looks good to me, nice work did you get the chance to run this and test it also?
|
@m0rphtail could you do a dry run with the above changes? I mean test it |
|
Have you tested this @xurror ? |
Author
|
Unfortunately no, I could not run proper tests on a secured endpoint. There
are some request header params I'm not able to set up
|
|
So we might need to test this before we go ahead with these changes. Maybe that could be something you might want to do this? Maybe using via the wallet client to make things easier. |
Author
|
Yes, I fear I will have to do that.
…On Tue, 19 May 2020 at 18:05, Maek Twain ***@***.***> wrote:
So we might need to test this before we go ahead with these changes. Maybe
that could be something you might want to do this? Maybe using via the
wallet client to make things easier.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK5B5DDAZVMY62A2XCMAOHLRSK36TANCNFSM4NAD2DDQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.