documenting script parser thing#33
Open
Gusic06 wants to merge 1 commit into
Open
Conversation
I did some unholy things in this, goddamn
ScottN13
reviewed
Feb 18, 2024
ScottN13
left a comment
ScottN13
left a comment
Owner
There was a problem hiding this comment.
can it run other things aside from .py?
ScottN13
added
enhancement
TRC-Loop
reviewed
Feb 18, 2024
| with open(".\\boxpyshell.py", "r") as file: | ||
| _contents = file.read() | ||
| new_contents = f"import {script_name}\n{_contents}\nelif command == '{command_name}':\n {function_name}({*args}, {**kwargs})" | ||
| new_contents = f"import {script_name}\n{_contents}\nelif command == '{command_name}':\n {function_name}({*args}, {**kwargs})" # tbh idk what this does, but it works.. I think |
Collaborator
There was a problem hiding this comment.
If you don't know then don't comment it. This is unnecessary.
| def build_file(self, name: str) -> None: | ||
| self._contents = self.get_script_from_user(input("Path to the Script file -> ")) | ||
| self.name = f"{name}.py" if name[-3:] != ".py" else name | ||
| self._contents: str = self.get_script_from_user(input("Path to the Script file -> ")) |
Collaborator
There was a problem hiding this comment.
If you want to set the type then instead of doing ```
var: str = ...
Rather do
var = str(input())
Owner
|
also @Gusic06 did you test it to see if it breaks any normal command or init process? |
Collaborator
|
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some unholy things in this, goddamn