chore(ci): remove audit-gha-workflows org-required workflow#24
Closed
John-David Dalton (jdalton) wants to merge 1 commit into
Closed
chore(ci): remove audit-gha-workflows org-required workflow#24John-David Dalton (jdalton) wants to merge 1 commit into
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
The audit-gha-workflows.yml was injected into every fleet repo as an org-level required workflow. It ran a zizmor scan on every PR and push — which is already covered by: - pnpm run check (local dev + pre-commit) - the zizmor invocation in setup-security-tools/install.mts - the shared SocketDev/socket-registry CI workflow consumers Three redundant zizmor passes is wasted runner time + adds noise to every PR's checks panel. Removing the org-required surface so each repo can opt into zizmor where it makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the org-level required workflow
audit-gha-workflows.yml. It was injected into every fleet repo as a required check on every PR + push and ran azizmorscan.The same zizmor scan is already covered three other ways:
pnpm run check(local dev + pre-commit hook chain) runs zizmor as part of the standard fleet checksetup-security-tools/install.mtsinstalls zizmor for ad-hoc local invocationsSocketDev/socket-registryCI workflow consumers can opt into zizmor via the check phaseThree redundant zizmor passes per PR is wasted runner time + adds noise to every PR's checks panel.
What changes for consumers
Required workflow 'Audit GHA Workflows'check disappears from PR Checks panels across the fleetTest plan
SocketDev/workflowsitselfSocketDev/socket-libshows the required workflow disappeared from its Checks panel