Situation
Every now and then we have lines like the following in the codebase:
private static final Color AMBIENT_COLOR = Color.decode("#CFBFF5");Mostly for embeds and similar.
What
Right now this is scattered all over. To improve the "brand" and generally make it easier to tweak stuff, all these colors should be defined in a central place instead.
How
We should introduce a class for example called AmbientColors and that should then offer all sorts of colors currently found in our codebase (fulltext search for Color and see which fit, maybe not every color should be moved) and then move it over to the new class.
Pay attention to renaming the colors so that the context of each color becomes clear. For example ThisIsScamCommand#AMBIENT_COLOR can then be renamed to AmbientColors#Moderation and be shared with the other moderation related colors (light purple iirc).
Potentially also see if the colors can be aligned a bit in purpose, up to the implementor though, not important for now.
Situation
Every now and then we have lines like the following in the codebase:
Mostly for embeds and similar.
What
Right now this is scattered all over. To improve the "brand" and generally make it easier to tweak stuff, all these colors should be defined in a central place instead.
How
We should introduce a class for example called
AmbientColorsand that should then offer all sorts of colors currently found in our codebase (fulltext search for Color and see which fit, maybe not every color should be moved) and then move it over to the new class.Pay attention to renaming the colors so that the context of each color becomes clear. For example
ThisIsScamCommand#AMBIENT_COLORcan then be renamed toAmbientColors#Moderationand be shared with the other moderation related colors (light purple iirc).Potentially also see if the colors can be aligned a bit in purpose, up to the implementor though, not important for now.