BUG: Gate in branch protection not working

[brianamarie]

I've gone through several iterations to make this work (#69 #68) but nothing is letting me pass. I'm going to comment out those things for now, and maybe @JasonEtco can help us out with it once he's online. cc @ppremk @a-a-ron @hollenberry @beardofedu

[brianamarie]

Another thing I'm concerned about with this step: What if someone does the wrong branch protections, then does a review? How can they retrigger a check?

[JasonEtco]

Keeping a quick note for myself - the include operator needs to match exactly, but we're actually trying to match a Regular Expression. It won't include ci/circleci, but it might include ci/circleci: build. Not sure what the best way to test for that is right now.

[brianamarie]

Thank you @JasonEtco! It seems this is resolved, based on #78 and https://github.com/github/learning-lab/pull/938. ✨

[brianamarie]

In balancing between timeline and if this is worth being a blocker, I think this would be nice to have but doesn't stop users from continuing the course on the happy path. If it's an unhappy path, that still would be a pain, but also doesn't stop users from continuing. I'm removing the "must" label, and this can be something we improve in the future.