From ec08897173a43c20f71fd88c4b7c3a6299ef1daa Mon Sep 17 00:00:00 2001 From: ann0see <20726856+ann0see@users.noreply.github.com> Date: Fri, 19 Jun 2026 19:11:56 +0200 Subject: [PATCH 1/3] Apply suggested fix to src/util.h from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> --- src/util.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/util.h b/src/util.h index 355d962b32..d826a6cd5e 100644 --- a/src/util.h +++ b/src/util.h @@ -739,18 +739,18 @@ enum ESkillLevel }; // define the GUI RGB colors for each skill level -#define RGBCOL_R_SL_NOT_SET 255 -#define RGBCOL_G_SL_NOT_SET 255 -#define RGBCOL_B_SL_NOT_SET 255 -#define RGBCOL_R_SL_BEGINNER 255 -#define RGBCOL_G_SL_BEGINNER 255 -#define RGBCOL_B_SL_BEGINNER 200 -#define RGBCOL_R_SL_INTERMEDIATE 225 -#define RGBCOL_G_SL_INTERMEDIATE 255 -#define RGBCOL_B_SL_INTERMEDIATE 225 -#define RGBCOL_R_SL_SL_PROFESSIONAL 255 -#define RGBCOL_G_SL_SL_PROFESSIONAL 225 -#define RGBCOL_B_SL_SL_PROFESSIONAL 225 +#define RGBCOL_R_SL_NOT_SET 255 +#define RGBCOL_G_SL_NOT_SET 255 +#define RGBCOL_B_SL_NOT_SET 255 +#define RGBCOL_R_SL_BEGINNER 255 +#define RGBCOL_G_SL_BEGINNER 255 +#define RGBCOL_B_SL_BEGINNER 200 +#define RGBCOL_R_SL_INTERMEDIATE 225 +#define RGBCOL_G_SL_INTERMEDIATE 255 +#define RGBCOL_B_SL_INTERMEDIATE 225 +#define RGBCOL_R_SL_PROFESSIONAL 255 +#define RGBCOL_G_SL_PROFESSIONAL 225 +#define RGBCOL_B_SL_PROFESSIONAL 225 // Stereo signal level meter --------------------------------------------------- class CStereoSignalLevelMeter From 65adbe125710a2615ea4fbe27c6e68ccc528c57d Mon Sep 17 00:00:00 2001 From: Tony Mountifield Date: Fri, 19 Jun 2026 20:48:53 +0100 Subject: [PATCH 2/3] Also change places where values are used --- src/audiomixerboard.cpp | 6 +++--- src/clientsettingsdlg.cpp | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/audiomixerboard.cpp b/src/audiomixerboard.cpp index 20c823bf2f..37ca0ff968 100644 --- a/src/audiomixerboard.cpp +++ b/src/audiomixerboard.cpp @@ -503,9 +503,9 @@ void CChannelFader::SetupFaderTag ( const ESkillLevel eSkillLevel ) case SL_PROFESSIONAL: strStile += QString ( "background-color: rgb(%1, %2, %3); }" ) - .arg ( RGBCOL_R_SL_SL_PROFESSIONAL ) - .arg ( RGBCOL_G_SL_SL_PROFESSIONAL ) - .arg ( RGBCOL_B_SL_SL_PROFESSIONAL ); + .arg ( RGBCOL_R_SL_PROFESSIONAL ) + .arg ( RGBCOL_G_SL_PROFESSIONAL ) + .arg ( RGBCOL_B_SL_PROFESSIONAL ); break; default: diff --git a/src/clientsettingsdlg.cpp b/src/clientsettingsdlg.cpp index be3f55f3eb..ad92a0f8e1 100644 --- a/src/clientsettingsdlg.cpp +++ b/src/clientsettingsdlg.cpp @@ -704,7 +704,7 @@ CClientSettingsDlg::CClientSettingsDlg ( CClient* pNCliP, CClientSettings* pNSet pcbxSkill->addItem ( QIcon ( SLPixmap ), tr ( "Intermediate" ), SL_INTERMEDIATE ); - SLPixmap.fill ( QColor::fromRgb ( RGBCOL_R_SL_SL_PROFESSIONAL, RGBCOL_G_SL_SL_PROFESSIONAL, RGBCOL_B_SL_SL_PROFESSIONAL ) ); + SLPixmap.fill ( QColor::fromRgb ( RGBCOL_R_SL_PROFESSIONAL, RGBCOL_G_SL_PROFESSIONAL, RGBCOL_B_SL_PROFESSIONAL ) ); pcbxSkill->addItem ( QIcon ( SLPixmap ), tr ( "Expert" ), SL_PROFESSIONAL ); From 6a67474ecd9f18d245273e40deca7d5d1e0168f2 Mon Sep 17 00:00:00 2001 From: Tony Mountifield Date: Fri, 19 Jun 2026 20:51:19 +0100 Subject: [PATCH 3/3] Fix formatting --- src/util.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/util.h b/src/util.h index d826a6cd5e..38eb370f1d 100644 --- a/src/util.h +++ b/src/util.h @@ -739,18 +739,18 @@ enum ESkillLevel }; // define the GUI RGB colors for each skill level -#define RGBCOL_R_SL_NOT_SET 255 -#define RGBCOL_G_SL_NOT_SET 255 -#define RGBCOL_B_SL_NOT_SET 255 -#define RGBCOL_R_SL_BEGINNER 255 -#define RGBCOL_G_SL_BEGINNER 255 -#define RGBCOL_B_SL_BEGINNER 200 -#define RGBCOL_R_SL_INTERMEDIATE 225 -#define RGBCOL_G_SL_INTERMEDIATE 255 -#define RGBCOL_B_SL_INTERMEDIATE 225 -#define RGBCOL_R_SL_PROFESSIONAL 255 -#define RGBCOL_G_SL_PROFESSIONAL 225 -#define RGBCOL_B_SL_PROFESSIONAL 225 +#define RGBCOL_R_SL_NOT_SET 255 +#define RGBCOL_G_SL_NOT_SET 255 +#define RGBCOL_B_SL_NOT_SET 255 +#define RGBCOL_R_SL_BEGINNER 255 +#define RGBCOL_G_SL_BEGINNER 255 +#define RGBCOL_B_SL_BEGINNER 200 +#define RGBCOL_R_SL_INTERMEDIATE 225 +#define RGBCOL_G_SL_INTERMEDIATE 255 +#define RGBCOL_B_SL_INTERMEDIATE 225 +#define RGBCOL_R_SL_PROFESSIONAL 255 +#define RGBCOL_G_SL_PROFESSIONAL 225 +#define RGBCOL_B_SL_PROFESSIONAL 225 // Stereo signal level meter --------------------------------------------------- class CStereoSignalLevelMeter