Skip to content

Fix eventloop usage for haxe 5#2007

Open
tobil4sk wants to merge 4 commits into
openfl:developfrom
tobil4sk:feature/haxe5
Open

Fix eventloop usage for haxe 5#2007
tobil4sk wants to merge 4 commits into
openfl:developfrom
tobil4sk:feature/haxe5

Conversation

@tobil4sk

Copy link
Copy Markdown
Member

Haxe 5 nightlies have a new api for event loops: HaxeFoundation/haxe#12388

See the equivalent heaps patch: HeapsIO/heaps@d40f2d0#diff-c0fa4e889efa97012174175edcce85cc359792651eb5e7435d2f0c0ed26dec0a

@tobil4sk

Copy link
Copy Markdown
Member Author

I think this needs to be updated too:

haxe.MainLoop.runInMainThread($i{field.name}.bind($a{args}))

Also, this will have the same issue as the openfl dictionary size PR since haxe 5 preview 1 didn't have this updated api yet.

@player-03

Copy link
Copy Markdown
Contributor

Copying Josh's comment here so I can find it later:

I think we can merge more Haxe 5 stuff once they update their version to include preview.2. right now, nightlies are still called preview.1, but some big things have changed since the real preview.1 and we can't differentiate.

@MRK2009

MRK2009 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Wait, I have a question, what about the warnings when using nightly Haxe version?

@player-03

Copy link
Copy Markdown
Contributor

If they're related to the event loop, we could add them to this PR, otherwise it would be a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants