Fix: OpenCode event ingestion compatibility (fixes hanging "working..." state with OpenCode Adapter)#2704
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
vouch:unvouched
|
This PR might seem like a duplicate of #2673, and it kind of is, but 2673 removes the old event stream which would break and regress T3 code experience for users on Opencode versions that are lesser than <=0.14.40 (which relatively recent) |
ApprovabilityVerdict: Needs human review This PR modifies runtime event ingestion behavior by introducing a new global event API with fallback to legacy subscription. While well-tested with comprehensive coverage, changes to event processing pipelines that affect session state tracking warrant human review. You can customize Macroscope's approvability policy. Learn more. |
eersnington
changed the title
|
I'll hold off on updating the base branch as mr the O hates rebasing. If this is planned to be merged and the change looks good, do tag me and i'll update that asap |
…-29f.5) Assessed PR pingdotgg#2704 from pingdotgg/t3code which fixes OpenCode adapter event ingestion for CLI versions >= 1.14.40. The PR switches from legacy event.subscribe() to global.event endpoint, adding directory filtering and payload validation. The root cause: newer OpenCode versions wrap events in {directory, payload} envelopes, but handleSubscribedEvent reads event.properties directly, silently discarding all events. This causes the "working..." hang (pingdotgg#2644), blank chat (pingdotgg#2652), and frozen sessions (pingdotgg#2691). Verdict: Apply. Low merge risk — additive changes to OpenCodeAdapter.ts with graceful fallback for SDKs < 1.4.7. All three issues share the same root cause and are addressed.
Verified via git merge-tree: zero conflicts between upstream PR pingdotgg#2704 and fork HEAD. Both files diverge from merge base but changes land in non-overlapping regions — fork's Crypto.randomUUIDv4 refactor and buildEventBase rewrite don't touch the PR's new types, helpers, or startEventPump regions.
…e (t3-29f.9) Cherry-picked from upstream PR pingdotgg#2704 (bd4ac1a) by eersnington. Fixes OpenCode event ingestion for CLI >= 1.14.40 where events are wrapped in a { directory, payload } envelope via /global/event. The legacy event.subscribe path returned raw events that the adapter's handleSubscribedEvent couldn't unwrap, causing ALL events to be silently discarded — sessions hung in "working..." indefinitely. Changes: - Prefer global.event endpoint with directory filtering to prevent cross-session event contamination - Add parseOpenCodeSubscribedEvent() runtime validation to squelch malformed payloads instead of crashing the event pump - Fall back to legacy event.subscribe({ directory }) when global.event is unavailable (404 or TypeError) - Both paths use a session-scoped AbortController cancelled on scope close Tests: 18/18 pass (4 new cases: global events, directory filtering, malformed payload tolerance, legacy fallback). Fixes issues pingdotgg#2644, pingdotgg#2652, pingdotgg#2691 (all share the same root cause).
|
no longer an issue in opencode 1.15.x+ |
1 participant
Heya, I started using T3 code 2 days ago with the Openchud integration and I was quite surprised at it not working at all. I've forked T3 code to fix a lot of issues and I'm using the local build for now, but this change would make OpenCode adapter from currently unusable to slightly above usable.
What Changed
/global/eventfrom Opencood for runtime event ingestion and filter wrapped events by session directory/eventsubscription when global events are unavailable (a lot of chaps within the issue thread below downgraded to <=0.14.40, so this fix would make it work for older sessions too)Why
Fixes #2644
UI Changes
(sound on 👁️👃👁️🦻)
t3code.pr.1.mp4
Checklist
Note
Medium Risk
Changes OpenCode session event ingestion to prefer a new global event stream and adds fallback logic, which can affect turn completion and session lifecycle behavior if event formats or error detection differ across OpenCode versions.
Overview
Switches the OpenCode adapter’s event pump to prefer
global.event(wrapped events) and projects provider runtime events only after filtering by sessiondirectoryand validating the wrapped payload shape.Adds compatibility fallback: if
global.eventis unavailable (e.g. 404 / TypeError), the adapter falls back toevent.subscribe(now called with{ directory }). Updates tests to cover global ingestion, directory filtering, malformed payload handling, and the fallback path.Reviewed by Cursor Bugbot for commit bd4ac1a. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix hanging "waiting..." state in OpenCode adapter by preferring
global.eventstream over legacyevent.subscribeglobal.eventendpoint, filtering bycontext.directoryto ignore events from other sessions and skipping malformed payloads.event.subscribepath (passing{ directory }as a parameter) whenglobal.eventreturns a 404 or aTypeErrorindicating the method is absent.AbortControllerthat is cancelled on scope close.Macroscope summarized bd4ac1a.