From b6f829238323d700e318742d578620a5ea09c699 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Wed, 1 Jul 2026 04:34:24 +0000
Subject: [PATCH] fix: repair cross-package bugs so all tests and type checks
 pass

- api.ts: import the actual useDebounce export (renamed from useThrottle)
  and re-export it as useSearchDebounce
- Button: extend ButtonHTMLAttributes and spread passthrough props so
  aria-label/disabled/onClick forward to the button; warn on icon-only
  buttons missing an aria-label (WCAG 4.1.2)
- date.ts: use UTC getters with an unpadded day so formatDate is
  timezone-deterministic and day 1 is not confused with month 1
- tsconfig: register bun-types and include app tests to resolve bun:test
---
 apps/web/src/lib/api.ts                      |  5 ++--
 packages/ui/src/components/Button/Button.tsx | 30 +++++---------------
 packages/utils/src/format/date.ts            | 10 +++----
 tsconfig.json                                |  3 +-
 4 files changed, 15 insertions(+), 33 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..e9e0a52 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -7,8 +7,7 @@
  * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -29,4 +28,4 @@ export async function fetchPosts() {
 export { formatDate, formatAUD }
 
 // Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+export { useDebounce as useSearchDebounce }
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..74dae9d 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -2,45 +2,29 @@ import React from "react"
 
 type Variant = "primary" | "secondary" | "danger"
 
-type Props = {
+type Props = React.ButtonHTMLAttributes<HTMLButtonElement> & {
   children?: React.ReactNode
-  /** Icon-only button — renders without visible text. Requires aria-label for accessibility. */
   icon?: React.ReactNode
   iconOnly?: boolean
   variant?: Variant
-  disabled?: boolean
-  onClick?: () => void
-  /** Accessible label — REQUIRED when iconOnly is true */
-  "aria-label"?: string
 }
 
-/**
- * Button component.
- *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
- */
 export function Button({
   children,
   icon,
   iconOnly = false,
   variant = "primary",
-  disabled = false,
-  onClick,
   "aria-label": ariaLabel,
+  ...rest
 }: Props) {
+  if (iconOnly && !ariaLabel) {
+    console.warn("Button: icon-only buttons must have an aria-label for WCAG 4.1.2 compliance.")
+  }
   return (
     <button
       className={`btn btn-${variant}`}
-      disabled={disabled}
-      onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={iconOnly ? (ariaLabel ?? "") : ariaLabel}
+      {...rest}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..03487fd 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -10,12 +10,10 @@
  * and rely on the locale to order them correctly.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
-    day: "numeric",
-    year: "numeric",
-  }).format(date)
+  const day = date.getUTCDate()
+  const month = String(date.getUTCMonth() + 1).padStart(2, "0")
+  const year = date.getUTCFullYear()
+  return `${day}/${month}/${year}`
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..3dfdf5c 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,10 +6,11 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]
     }
   },
-  "include": ["packages/*/src/**/*", "packages/*/test/**/*", "apps/*/src/**/*"]
+  "include": ["packages/*/src/**/*", "packages/*/test/**/*", "apps/*/src/**/*", "apps/*/test/**/*"]
 }