From 9715a246f9db5025cf7c13157b34b94ba3971bd5 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Sat, 4 Jul 2026 16:37:06 +0000
Subject: [PATCH] fix: repair cross-package bugs breaking tests and types

- utils: format day/month without leading zeros in formatDate (en-AU)
- utils/web: rename hook to useDebounce; re-export as useSearchDebounce
- ui: pass through aria-label on icon-only Button, warn when missing
- ui: fix stale-closure in DataTable sort toggle via functional updater
- tsconfig: register bun-types so bun:test resolves in test files
---
 apps/web/src/lib/api.ts                            |  4 ++--
 packages/ui/src/components/Button/Button.tsx       | 10 ++++++++--
 packages/ui/src/components/DataTable/DataTable.tsx |  2 +-
 packages/utils/src/format/date.ts                  | 10 ++++++----
 tsconfig.json                                      |  2 ++
 5 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..4df4cfc 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -8,7 +8,7 @@
  */
 
 // BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -29,4 +29,4 @@ export async function fetchPosts() {
 export { formatDate, formatAUD }
 
 // Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+export { useDebounce as useSearchDebounce }
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..7130593 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -34,13 +34,19 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  if (iconOnly && !ariaLabel) {
+    console.warn(
+      "Button: icon-only buttons require an aria-label for accessibility (WCAG 4.1.2). " +
+        "Pass aria-label=\"<description>\" to this Button."
+    )
+  }
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={iconOnly ? (ariaLabel ?? "") : ariaLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..fb5b629 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -31,7 +31,7 @@ export function DataTable<T extends Record<string, unknown>>({ data, columns }:
   // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir(prev => prev === "asc" ? "desc" : "asc")
     } else {
       setSortKey(key)
       setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..66e85b5 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -10,12 +10,14 @@
  * and rely on the locale to order them correctly.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  const parts = new Intl.DateTimeFormat("en-AU", {
     day: "numeric",
+    month: "numeric",
     year: "numeric",
-  }).format(date)
+  }).formatToParts(date)
+  const get = (type: string) =>
+    String(parseInt(parts.find(p => p.type === type)?.value ?? "0", 10))
+  return `${get("day")}/${get("month")}/${get("year")}`
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..de2dd4d 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,8 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "lib": ["ES2022", "DOM", "DOM.Iterable"],
+    "types": ["bun-types", "react"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]