Skip to content

chore: remove unsued assign-role component file#1684

Merged
rohilsurana merged 1 commit into
mainfrom
chore_admin_remove_policies_api
Jun 9, 2026
Merged

chore: remove unsued assign-role component file#1684
rohilsurana merged 1 commit into
mainfrom
chore_admin_remove_policies_api

Conversation

@rsbh

@rsbh rsbh commented Jun 8, 2026

Copy link
Copy Markdown
Member

Summary

Changes

Technical Details

Test Plan

  • Manual testing completed
  • Build and type checking passes

SQL Safety (if your PR touches *_repository.go or goqu.*)

  • Values flow through ? placeholders, goqu.Ex{}, or goqu.Record{} — never fmt.Sprintf or + building a query that gets executed.
  • ToSQL() callers capture and forward params (query, params, err := stmt.ToSQL(); db.…Context(ctx, …, query, params...)). Never query, _, err := ….
  • No ? placeholders inside single-quoted SQL literals in goqu.L (use make_interval(hours => ?)-style functions instead).
  • Any //nolint:forbidigo or // #nosec G20x annotation has a one-line justification on the same line that a reviewer can verify.

@vercel

vercel Bot commented Jun 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Jun 8, 2026 4:12am

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c9863845-b6b0-47d0-8575-b4c4dcadc982

📥 Commits

Reviewing files that changed from the base of the PR and between 00f567b and 94386b9.

📒 Files selected for processing (1)
  • web/apps/admin/src/components/assign-role.tsx
💤 Files with no reviewable changes (1)
  • web/apps/admin/src/components/assign-role.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Removed the role assignment dialog functionality from the admin panel. Users can no longer reassign roles through this interface.

Walkthrough

The AssignRole React component has been removed from the admin application. This component provided a dialog interface for role reassignment, managing selected role IDs via react-hook-form and performing deletions and creations of policies through FrontierService.

Changes

Cohort / File(s) Summary
AssignRole component removal
web/apps/admin/src/components/assign-role.tsx
Complete removal of the AssignRole dialog component (215 lines), including the exported component, TypeScript props interface, form logic using react-hook-form, role validation, policy management calls to FrontierService, and associated UI elements.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • rohilsurana
  • rohanchkrabrty
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 27115525346

Coverage remained the same at 43.221%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 38046
Covered Lines: 16444
Line Coverage: 43.22%
Coverage Strength: 12.14 hits per line

💛 - Coveralls

@rohilsurana rohilsurana merged commit 0e40faf into main Jun 9, 2026
8 checks passed
@rohilsurana rohilsurana deleted the chore_admin_remove_policies_api branch June 9, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants