Skip to content

move JsxDOM.dromProps and JsxDOMStyle from compiler to @rescript/react #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dkirchhof wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

move JsxDOM.dromProps and JsxDOMStyle from compiler to @rescript/react #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f95e59d
move JsxDOM.dromProps and JsxDOMStyle from compiler to rescript/react
dkirchhof Mar 7, 2026
96baf19
version bump
dkirchhof Mar 8, 2026
9377bee
Merge branch 'master' into add-domprops-and-domstyles
dkirchhof May 14, 2026
abaa73d
add reactdomevent and use it in reactdomprops
dkirchhof May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@
"react": ">=19.2.0",
"react-dom": ">=19.2.0"
}
}
}
2 changes: 1 addition & 1 deletion src/React.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ type componentLike<'props, 'return> = Jsx.componentLike<'props, 'return>

type component<'props> = Jsx.component<'props>

external component: componentLike<'props, element> => component<'props> = "%identity"
external component: componentLike<'props, element> => component<'props> = "%component_identity"

@module("react")
external createElement: (component<'props>, 'props) => element = "createElement"
Expand Down
16 changes: 7 additions & 9 deletions src/ReactDOM.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ external domElementToObj: Dom.element => {..} = "%identity"

type style = ReactDOMStyle.t

type domRef = JsxDOM.domRef
type domRef

module Ref = {
type t = domRef
Expand Down Expand Up @@ -219,31 +219,29 @@ external preinitModule: (string, preloadModuleOptions) => unit = "preinitModule"

// Runtime

type domProps = JsxDOM.domProps

@variadic @module("react")
external createElement: (string, ~props: domProps=?, array<React.element>) => React.element =
external createElement: (string, ~props: ReactDOMProps.t=?, array<React.element>) => React.element =
"createElement"

@variadic @module("react")
external createDOMElementVariadic: (
string,
~props: domProps=?,
~props: ReactDOMProps.t=?,
array<React.element>,
) => React.element = "createElement"

external someElement: React.element => option<React.element> = "%identity"

@module("react/jsx-runtime")
external jsx: (string, JsxDOM.domProps) => Jsx.element = "jsx"
external jsx: (string, ReactDOMProps.t) => Jsx.element = "jsx"

@module("react/jsx-runtime")
external jsxKeyed: (string, JsxDOM.domProps, ~key: string=?, @ignore unit) => Jsx.element = "jsx"
external jsxKeyed: (string, ReactDOMProps.t, ~key: string=?, @ignore unit) => Jsx.element = "jsx"

@module("react/jsx-runtime")
external jsxs: (string, JsxDOM.domProps) => Jsx.element = "jsxs"
external jsxs: (string, ReactDOMProps.t) => Jsx.element = "jsxs"

@module("react/jsx-runtime")
external jsxsKeyed: (string, JsxDOM.domProps, ~key: string=?, @ignore unit) => Jsx.element = "jsxs"
external jsxsKeyed: (string, ReactDOMProps.t, ~key: string=?, @ignore unit) => Jsx.element = "jsxs"

module Style = ReactDOMStyle
Loading
Loading