Skip to content

revert: hash pinning on pypi publish workflow#981

Closed
bhearsum wants to merge 1 commit into
taskcluster:mainfrom
bhearsum:pin2
Closed

revert: hash pinning on pypi publish workflow#981
bhearsum wants to merge 1 commit into
taskcluster:mainfrom
bhearsum:pin2

Conversation

@bhearsum

@bhearsum bhearsum commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Missed these ones in #980

(We're already talking about accepting the pinning and loosening the restrictions on the versions of this action that may run; but we may want this to unbreak releases in the meantime.)

@bhearsum bhearsum requested a review from a team as a code owner June 9, 2026 18:17
@bhearsum bhearsum requested a review from jcristau June 9, 2026 18:17
@codspeed-hq

codspeed-hq Bot commented Jun 9, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 12.01%

⚡ 1 improved benchmark
✅ 23 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
test_transform_sequence 6.8 ms 6.1 ms +12.01%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing bhearsum:pin2 (1a21cf2) with main (bc32359)

Open in CodSpeed

@ahal ahal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and relaxed the pypi-publish restriction in the settings. After looking into it, I think we should keep the hash pinning.

@ahal

ahal commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Outlined my rationale in channel, copy/pasting here:

I think I understand.. The release/v1 branch is like a latest tag.. it points to whatever the latest release on the 1.x branch line is:
https://github.com/pypa/gh-action-pypi-publish/tree/release/v1

but because we're using renovate now, it'll find the tag refs directly.. so it's likely equivalent to using release/v1 but we get to update explicitly instead of implicitly

@bhearsum

bhearsum commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

ok, sure

@bhearsum bhearsum closed this Jun 9, 2026
@bhearsum

bhearsum commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

#982 for moving back to hash pinning.

ahal pushed a commit that referenced this pull request Jun 9, 2026
Quoting context from @ahal in #981:

> Outlined my rationale in channel, copy/pasting here:
> 
> I think I understand.. The release/v1 branch is like a latest tag.. it points to whatever the latest release on the 1.x branch line is: https://github.com/pypa/gh-action-pypi-publish/tree/release/v1
> 
> but because we're using renovate now, it'll find the tag refs directly.. so it's likely equivalent to using release/v1 but we get to update explicitly instead of implicitly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants