Follow up fix custom flash block sizes fallback in Ulysses attention#437
Merged
Conversation
Perseus14
previously approved these changes
Jul 2, 2026
ninatu
force-pushed
the
ninatu/fix_heads_per_tile2
branch
3 times, most recently
from
da3dbfc to
322fb6b
Compare
Collaborator
|
@eltsai can you review these changes? |
ninatu
force-pushed
the
ninatu/fix_heads_per_tile2
branch
2 times, most recently
from
6e416fb to
58b6714
Compare
eltsai
previously approved these changes
Jul 9, 2026
eltsai
reviewed
Jul 9, 2026
| # to 1 (the custom-kernel default) to keep the `heads_per_tile > 1` guards safe. | ||
| heads_per_tile = getattr(flash_block_sizes, "heads_per_tile", None) or heads_per_tile | ||
| vmem_limit_bytes = getattr(flash_block_sizes, "vmem_limit_bytes", None) or vmem_limit_bytes | ||
| return bq, bkv, bkv_compute, bkv_compute_in, heads_per_tile, vmem_limit_bytes |
Collaborator
There was a problem hiding this comment.
can we add a if heads_per_tile is None 0 -> heads_per_tile = 1 safety check before return? This PR lgtm otherwise
Collaborator
Author
There was a problem hiding this comment.
Okay, I reverted this lines back, now after this block we have
if heads_per_tile is None:
heads_per_tile = 1
Ensure that block sizes and heads_per_tile fall back to default values when resolved as None from CustomFlashBlockSizes dataclass. This fixes a TypeError in ulysses_custom attention when heads_per_tile is not specified.
ninatu
force-pushed
the
ninatu/fix_heads_per_tile2
branch
from
58b6714 to
b1265c7
Compare
eltsai
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same fix as in #420 since bug was reintroduced again in #430 during refactoring