[PWGLF] Replace cone radius calculation with rJet#16292
Merged
Conversation
alcaliva
requested review from
alibuild,
ercolessi,
lhusova,
mpuccio,
omvazque,
romainschotter and
skundu692
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
romainschotter
requested changes
May 18, 2026
Collaborator
romainschotter
left a comment
romainschotter
left a comment
There was a problem hiding this comment.
Hi @alcaliva ! It looks all fine.
But can you please just address the warnings concerning Use constant references for non-modified iterators in range-based for loops.? These can improve the performance of the task.
Thank you very much!
Collaborator
Author
|
Hi Romain, I fixed the linter already. Did I miss something? |
Collaborator
|
Hi @alcaliva ! My mistake! On my side, I saw some warnings still but they are no longer there. |
romainschotter
approved these changes
May 18, 2026
vkucera
reviewed
May 25, 2026
| continue; | ||
|
|
||
| if (std::abs(motherPos.eta()) > 0.8) | ||
| double maxPseudorap = 0.8; |
vkucera
reviewed
May 25, 2026
| } | ||
|
|
||
| for (auto& particle : mcParticlesPerColl) { | ||
| const double maxPseudorap = 0.8; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.