[PWGEM/Dilepton] update taggingHFE#16326
Merged
Merged
Conversation
dsekihat
requested review from
alibuild,
feisenhu,
hscheid,
jokonig,
mikesas and
rbailhac
as code owners
|
O2 linter results: ❌ 413 errors, |
Please consider the following formatting changes to AliceO2Group#16326
dsekihat
changed the title
Collaborator
|
Error while checking build/O2Physics/o2 for 8864d12 at 2026-05-20 19:18: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 8864d12 at 2026-05-20 19:19: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for c03142e at 2026-05-20 19:27: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for c03142e at 2026-05-20 19:29: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 1f50a75 at 2026-05-20 19:30: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 1f50a75 at 2026-05-20 19:34: Full log here. |
vkucera
reviewed
May 25, 2026
Collaborator
There was a problem hiding this comment.
Most of the includes are unused. How did you come up with this list?
vkucera
reviewed
May 25, 2026
Collaborator
There was a problem hiding this comment.
Again. Most includes are unused. You are supposed to clean them up before making the PR.
vkucera
reviewed
May 25, 2026
| class ElectronModule | ||
| { | ||
| public: | ||
| ElectronModule() |
vkucera
reviewed
May 25, 2026
| DECLARE_SOA_COLUMN(HadronType, hadronType, std::vector<uint8_t>); //! 0:track, 1:K0S, 2:Lambda, 3:AntiLambda, 4:XiMinus, 5:XiPlus, 6:OmegaMinus, 7:OmegaPlus | ||
|
|
||
| DECLARE_SOA_DYNAMIC_COLUMN(ProbaSCT, probaSCT, [](std::vector<float> p0, std::vector<float> p1, std::vector<float> p2, std::vector<float> p3, std::vector<uint8_t> type, int index) -> std::array<float, 5> { return std::array<float, 5>{p0[index], p1[index], p2[index], p3[index], static_cast<float>(type[index])}; }); | ||
| DECLARE_SOA_DYNAMIC_COLUMN(NSV, nSV, [](std::vector<uint8_t> type) -> size_t { return type.size(); }); |
Collaborator
There was a problem hiding this comment.
Do not pass vectors by value.
vkucera
reviewed
May 25, 2026
| return false; | ||
| } | ||
|
|
||
| if (!fElectronCut.includeITSsa && (!track.hasITS() || !track.hasTPC())) { |
Collaborator
There was a problem hiding this comment.
!track.hasITS() is always false.
vkucera
reviewed
May 25, 2026
| auto trackParCov2 = getTrackParCov(looseElectron); | ||
| trackParCov2.setPID(o2::track::PID::Electron); | ||
| bool isPropOK = o2::base::Propagator::Instance()->propagateToDCABxByBz(mVtx, trackParCov2, 2.f, matCorr, &mDcaInfoCov); | ||
| if (!isPropOK) { |
vkucera
reviewed
May 25, 2026
|
|
||
| auto hadronParCov = getTrackParCov(hadron); | ||
| o2::dataformats::DCA mDcaInfoCov; | ||
| mDcaInfoCov.set(999, 999, 999, 999, 999); |
vkucera
reviewed
May 25, 2026
| std::unordered_map<int, double> mapCollisionTime; | ||
| std::unordered_map<int, double> mapCollisionTimeError; | ||
| for (const auto& track : tracks) { | ||
| if (mapCollisionTime.find(track.collisionId()) == mapCollisionTime.end()) { |
Collaborator
There was a problem hiding this comment.
Searching before insertion is not necessary. Instead of mapCollisionTime[track.collisionId()]=track.tofEvTime() consider using mapCollisionTime.try_emplace(track.collisionId(), track.tofEvTime());.
vkucera
reviewed
May 25, 2026
| }; | ||
| } | ||
|
|
||
| uint8_t mCachedIndexBinning; // index correspondance between configurable and available input features |
vkucera
reviewed
May 25, 2026
| }; | ||
| } | ||
|
|
||
| uint8_t mCachedIndexBinning; // index correspondance between configurable and available input features |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[PWGEM/Dilepton] update taggingHFE