[PWGCF] Add task for TrackTrackCascade analysis#16371
Open
Roberta-Ferioli wants to merge 5 commits into
Open
Conversation
Roberta-Ferioli
requested review from
alibuild,
ariedel-cern,
lauraser,
otonvd,
shouqiye and
victor-gonzalez
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#16371
Collaborator
|
Error while checking build/O2Physics/o2 for c407fb2 at 2026-05-25 11:04: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for c407fb2 at 2026-05-25 11:07: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 0912657 at 2026-05-25 11:13: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 0912657 at 2026-05-25 11:15: Full log here. |
Roberta-Ferioli
changed the title
Collaborator
|
Error while checking build/O2Physics/o2 for 66f3f9e at 2026-05-25 17:05: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 66f3f9e at 2026-05-25 17:06: Full log here. |
Collaborator
|
@Roberta-Ferioli Please make sure your changes compile without warnings before you open a PR. |
Contributor
Author
|
Thank you for the suggestion. In my local version there weren't warning. Anyway I fixed the one suggested by alibuild. Now it should be ok |
vkucera
reviewed
May 26, 2026
Comment on lines
+628
to
+676
| template <modes::Cascade cascadeType, | ||
| const char* prefixTrack1, | ||
| const char* prefixTrack2, | ||
| const char* prefixCascade, | ||
| const char* prefixBachelor, | ||
| const char* prefixPosDau, | ||
| const char* prefixNegDau, | ||
| const char* prefixSe, | ||
| const char* prefixMe, | ||
| const char* prefixCtrTrack1Track2Se, | ||
| const char* prefixCprBachelorTrack1Se, | ||
| const char* prefixCprBachelorTrack2Se, | ||
| const char* prefixCprV0DaughterTrack1Se, | ||
| const char* prefixCprV0DaughterTrack2Se, | ||
| const char* prefixCtrTrack1Track2Me, | ||
| const char* prefixCprBachelorTrack1Me, | ||
| const char* prefixCprBachelorTrack2Me, | ||
| const char* prefixCprV0DaughterTrack1Me, | ||
| const char* prefixCprV0DaughterTrack2Me> | ||
| class TripletTrackTrackCascadeBuilder | ||
| { | ||
| public: | ||
| TripletTrackTrackCascadeBuilder() = default; | ||
| ~TripletTrackTrackCascadeBuilder() = default; | ||
|
|
||
| template <modes::Mode mode, | ||
| typename T1, | ||
| typename T2, | ||
| typename T3, | ||
| typename T4, | ||
| typename T5, | ||
| typename T6, | ||
| typename T7, | ||
| typename T8, | ||
| typename T9, | ||
| typename T10, | ||
| typename T11, | ||
| typename T12, | ||
| typename T13, | ||
| typename T14, | ||
| typename T15, | ||
| typename T16, | ||
| typename T17, | ||
| typename T18, | ||
| typename T19, | ||
| typename T20, | ||
| typename T21, | ||
| typename T22, | ||
| typename T23> |
Collaborator
There was a problem hiding this comment.
Do you really need to have 19 template parameters for the class and 23 template parameters for its method??? This might cause a huge compilation time and memory overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add task in the new framework for the TrackTrackCascade analysis. @rdelgran @ariedel-cern @gmantzar