Skip to content

[Common,PWGLF] Add TOF NSigma from TOF PID framework#16393

Open
romainschotter wants to merge 32 commits into
AliceO2Group:masterfrom
romainschotter:strangenesstof
Open

[Common,PWGLF] Add TOF NSigma from TOF PID framework#16393
romainschotter wants to merge 32 commits into
AliceO2Group:masterfrom
romainschotter:strangenesstof

Conversation

@romainschotter
Copy link
Copy Markdown
Collaborator

@romainschotter romainschotter commented May 26, 2026

  • Add TOF NSigma from TOF PID framework in the strangeness TOF PID (thanks @dsekihat )
  • Collision time and time error are calculated as the average of the tracks' time and time error
  • change PIDTOFParamService to allow using the TOF Nsigma from TOF PID framework when running over strangeness derived data (otherwise ccdb configurables are always fetched from the tof-signal task)

@njacazio @dsekihat for your information

@njacazio
Copy link
Copy Markdown
Collaborator

Ciao @romainschotter that's great thanks!
Since they are orthogonal, could you split the two changes in two PRs? i.e. one for the inheritance, one for the rest?
Apart from that looks good, many thanks!
Cheers,
N.

njacazio
njacazio previously approved these changes May 26, 2026
@@ -112,6 +112,7 @@ DECLARE_SOA_INDEX_COLUMN(DauTrackExtra, dauTrackExtra); //! point to daughter th
DECLARE_SOA_INDEX_COLUMN(StraCollision, straCollision); //! point to collision associated with this track (not the V0/Casc)
DECLARE_SOA_COLUMN(TOFSignal, tofSignal, float); //! track TOF signal
DECLARE_SOA_COLUMN(TOFEvTime, tofEvTime, float); //! event time
DECLARE_SOA_COLUMN(TOFEvTimeErr, tofEvTimeErr, float); //! event time error for TOF
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This in principle could be left and in the table the value from https://github.com/AliceO2Group/O2Physics/blob/master/Common/DataModel/PIDResponseTOF.h#L304

@romainschotter
Copy link
Copy Markdown
Collaborator Author

Ciao @njacazio !
Of course, I can split the PR into two PRs but the strangenesstofpid task won't work anymore when running over derived data and using the TOF framework to calculate the TOF NSigma (at least, until the second PR would be merged).
That's because the PIDTOFParamService expects the workflow to depend on the tof-signal task, which carries the CCDB configuration for the PIDTOFParamService. In order to have a self-consistent PR, I have put together the changes in the strangeness and TOF frameworks.
Actually, this makes me realize that I forgot to add a commit to the PR (the one where we tell the PIDTOFParamService from which task the CCDB configuration should be taken from)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2026

O2 linter results: ❌ 232 errors, ⚠️ 88 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add TOF NSigma from TOF PID framework [Common,PWGLF] Add TOF NSigma from TOF PID framework May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants