Skip to content

[PWGHF] Update tree creator for Xic0Omegac0#16421

Open
jinhyunni wants to merge 8 commits into
AliceO2Group:masterfrom
jinhyunni:updateworkflow
Open

[PWGHF] Update tree creator for Xic0Omegac0#16421
jinhyunni wants to merge 8 commits into
AliceO2Group:masterfrom
jinhyunni:updateworkflow

Conversation

@jinhyunni
Copy link
Copy Markdown
Contributor

@jinhyunni jinhyunni commented May 27, 2026

Modified treeCreatorToXiPiQa.cxx to support saving an output table with generated-particle information.

@github-actions github-actions Bot added the pwghf PWG-HF label May 27, 2026
@github-actions github-actions Bot changed the title Update tree creator for Xic0Omegac0 [PWGHF] Update tree creator for Xic0Omegac0 May 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#16421
@vkucera vkucera marked this pull request as draft May 27, 2026 15:00
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 27, 2026

You are repeating the same block 11 times!

Comment thread PWGHF/TableProducer/treeCreatorToXiPiQa.cxx Outdated
Comment thread PWGHF/TableProducer/treeCreatorToXiPiQa.cxx
Comment thread PWGHF/TableProducer/treeCreatorToXiPiQa.cxx Outdated
@jinhyunni
Copy link
Copy Markdown
Contributor Author

You are repeating the same block 11 times!

I've written a helper function to fill in particle table to enhance code maintainence.

@jinhyunni jinhyunni marked this pull request as ready for review May 27, 2026 16:17
@jinhyunni
Copy link
Copy Markdown
Contributor Author

Hi @vkucera, I've tried compiling O2Physics with this PR and found no issues.
However, masOS build cheks are failing.
Can you direct me how to solve this issue?

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 28, 2026

Hi @vkucera, I've tried compiling O2Physics with this PR and found no issues. However, masOS build cheks are failing. Can you direct me how to solve this issue?

You cannot use floating-point values as template arguments. Why would you do it anyway? The mass value does not change the code.

@jinhyunni
Copy link
Copy Markdown
Contributor Author

jinhyunni commented May 28, 2026

Hi @vkucera, I've tried compiling O2Physics with this PR and found no issues. However, masOS build cheks are failing. Can you direct me how to solve this issue?

You cannot use floating-point values as template arguments. Why would you do it anyway? The mass value does not change the code.

I wasn't aware of that. Thanks for pointing that out.
I've assigned the mass as one of the arguement because this codes also aimes to be used for Omegac0 to Xi Pi analysis, following the old version of this workflow: treeCreatorToXiPi.cxx

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 28, 2026

Hi @vkucera, I've tried compiling O2Physics with this PR and found no issues. However, masOS build cheks are failing. Can you direct me how to solve this issue?

You cannot use floating-point values as template arguments. Why would you do it anyway? The mass value does not change the code.

I wasn't aware of that. Thanks for pointing that out. I've assigned the mass as one of the arguement because this codes also aimes to be used for Omegac0 to Xi Pi analysis, following the old version of this workflow: treeCreatorToXiPi.cxx

I understand you want the function to be able to digest different mass values but a simple function argument should work fine, no? Template arguments are for generating different versions of the code which does not seem to be the case here.

@jinhyunni
Copy link
Copy Markdown
Contributor Author

Hi @vkucera, I've tried compiling O2Physics with this PR and found no issues. However, masOS build cheks are failing. Can you direct me how to solve this issue?

You cannot use floating-point values as template arguments. Why would you do it anyway? The mass value does not change the code.

I wasn't aware of that. Thanks for pointing that out. I've assigned the mass as one of the arguement because this codes also aimes to be used for Omegac0 to Xi Pi analysis, following the old version of this workflow: treeCreatorToXiPi.cxx

I understand you want the function to be able to digest different mass values but a simple function argument should work fine, no? Template arguments are for generating different versions of the code which does not seem to be the case here.

Yes, I fully agree with you. It was my mistake to assign mass arguement to template arguement.
I'll make a comit which fixes this issue.

Thanks again :)

@jinhyunni
Copy link
Copy Markdown
Contributor Author

Dear @vkucera,
I've fixed the helper function as you've adviced.
Could you have a look and approve this PR if it's okay?

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 28, 2026

Dear @vkucera, I've fixed the helper function as you've adviced. Could you have a look and approve this PR if it's okay?

Thanks, looks good to me.

@jinhyunni
Copy link
Copy Markdown
Contributor Author

Dear @zhangbiao-phy,

I've prepared a PR to update tree creator of Xic0Omegac0 workflow.
It aims to support saving an output table with generated-particle information.
Could you have a look and merge this PR if it looks fine for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants