[PWGLF,PWGMM] Add event selection on ITS layers#16451
Open
gbencedi wants to merge 3 commits into
Open
Conversation
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
Collaborator
|
@gbencedi Please check your compilation before you open a PR. |
vkucera
reviewed
May 29, 2026
Comment on lines
92
to
96
| auto static constexpr CintZero = 0; | ||
| auto static constexpr CintOne = 1; | ||
| auto static constexpr CintTwo = 2; | ||
| auto static constexpr Czero = 0.f; | ||
| auto static constexpr Cninety = 90.f; |
Collaborator
There was a problem hiding this comment.
These are just numbers named after their values. This is as meaningless as using the numbers directly. The purpose of avoiding magic numbers is to link the values to their meanings. This is just silencing the linter error without actually following the rationale behind the error.
Collaborator
Author
There was a problem hiding this comment.
Indeed, I will pay attention to that in the next commit.
abmodak
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.