Remove legacy creator node SDK defaults#14476
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 47c3878 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14476.audius.workers.dev Unique preview for this PR (deployed from this branch). |
raymondjacobson
force-pushed
the
codex/remove-sdk-hardcoded-creatornodes
branch
from
2ffad4d to
47c3878
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateServicesConfig.tsso generated production SDK storage-node defaults use the canonical Audius storage-node hostname.creatornode2.audius.coandcreatornode3.audius.coare no longer inpackages/sdk.@audius/sdk.Validation
rg -n "creatornode2|creatornode3" packages/sdkhas no matches.git diff --check origin/main...HEADNot run
npm run sdk:config -w @audius/sdk, package typecheck, or tests; this checkout has nonode_modules, and no npm/yarn/pnpm/corepack executable is available on PATH.