Skip to content

Refresh azure-mgmt-advisor after migrate to Typespec#47893

Open
azure-sdk-automation[bot] wants to merge 3 commits into
mainfrom
sdkauto/azure-mgmt-advisor-6527980
Open

Refresh azure-mgmt-advisor after migrate to Typespec#47893
azure-sdk-automation[bot] wants to merge 3 commits into
mainfrom
sdkauto/azure-mgmt-advisor-6527980

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Configurations: 'specification/advisor/resource-manager/Microsoft.Advisor/Advisor/tspconfig.yaml', API Version: 2026-03-01-preview, SDK Release Type: beta, and CommitSHA: 'a7bdbe741c0ef1f1b159d8569b173757bd823ae9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6527980 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

…isor/Advisor/tspconfig.yaml', API Version: 2026-03-01-preview, SDK Release Type: beta, and CommitSHA: 'a7bdbe741c0ef1f1b159d8569b173757bd823ae9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6527980 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@msyyc msyyc changed the title [AutoPR azure-mgmt-advisor]-generated-from-SDK Generation - Python-6527980 Refresh azure-mgmt-advisor after migrate to Typespec Jul 7, 2026
@msyyc msyyc marked this pull request as ready for review July 7, 2026 07:30
@msyyc msyyc requested a review from ChenxiJiang333 as a code owner July 7, 2026 07:30
Copilot AI review requested due to automatic review settings July 7, 2026 07:30
@msyyc msyyc self-requested a review as a code owner July 7, 2026 07:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refreshes the azure-mgmt-advisor package by regenerating it from TypeSpec (moving off AutoRest) against API version 2026-03-01-preview. It bumps the package from the stable 9.0.1 to the preview 10.0.0b2, adds several new operation groups (advisor scores, assessments, assessment types, resiliency reviews, workloads) plus a top-level predict method, and restructures existing models to nest properties under a properties bag with backward-compatible attribute flattening (e.g., ConfigData).

Changes:

  • Regenerate the SDK from TypeSpec: new client (_client.py), models (_models, _enums), operations, validation/serialization helpers, and refreshed samples/tests.
  • Version/metadata updates: 10.0.0b2, is_stable=false, Beta classifiers, requires-python>=3.10 (drops 3.9, adds 3.14), new _metadata.json/apiview-properties.json.
  • CHANGELOG documents new features and breaking changes; README auth section updated to Microsoft Entra wording.

Reviewed changes

Copilot reviewed 95 out of 97 changed files in this pull request and generated no comments.

Show a summary per file
File Description
azure/mgmt/advisor/_client.py (+aio) New client with added operation groups; send_request now public. Contains the non-standard resiliencyReviewsOperations class name.
azure/mgmt/advisor/_configuration.py (+aio) Adds base_url param and new default API version 2026-03-01-preview.
_version.py Bumps to 10.0.0b2 (matches CHANGELOG).
pyproject.toml Beta stability flags, Python version range update.
CHANGELOG.md Documents 10.0.0b2 features and breaking changes (dated 2026-07-07).
README.md Auth wording updated to Microsoft Entra; client usage matches API.
models/*, operations/*, _utils/*, _validation.py Generated model/operation/serialization refactor (incl. ConfigData flattening shim).
tsp-location.yaml, _metadata.json, apiview-properties.json, api.metadata.yml New TypeSpec generation metadata.
tests/test_mgmt_advisor.py, tests/conftest.py Black reformatting only; behavior unchanged.
generated_samples/*, generated_tests/* Regenerated (not reviewed per MGMT rules).
Comments suppressed due to low confidence (1)

sdk/advisor/azure-mgmt-advisor/azure/mgmt/advisor/_client.py:143

  • The operation group class resiliencyReviewsOperations uses a lowercase-first (camelCase) name, which is inconsistent with every other operation group class in this package (AdvisorScoresOperations, AssessmentsOperations, AssessmentTypesOperations, WorkloadsOperations, ConfigurationsOperations, etc., all PascalCase). Because the class is public API — it is exported from operations/__init__.py, appears in the client docstring :vartype resiliency_reviews: azure.mgmt.advisor.operations.resiliencyReviewsOperations, and is used here — this inconsistency is user-visible. The same non-standard name also appears in the async client, both operations/__init__.py files, and the CHANGELOG. This originates from the TypeSpec operation group name; consider correcting it in the spec (e.g. via a PascalCase interface name or @clientName) and regenerating so the class becomes ResiliencyReviewsOperations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants