Refresh azure-mgmt-domainservices after migrate to Typespec#47909
Refresh azure-mgmt-domainservices after migrate to Typespec#47909azure-sdk-automation[bot] wants to merge 1 commit into
Conversation
…oft.AAD/DomainServices/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '88976ab9ea9fb7f69533fbd465540060bd1f225a' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6528511 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Pull request overview
This PR is an automated (azure-sdk-automation bot) refresh of the management-plane package azure-mgmt-domainservices, migrating it to a TypeSpec-generated SDK for API version 2025-10-01-preview (beta release type). It scaffolds the full package: build/packaging metadata, README, license, CI pipeline definition, TypeSpec location pointer, generated client/operations/models, and generated (skipped) tests. The public client is DomainServicesMgmtClient, and the signature/name/stability conventions are all consistent.
The one blocking problem is versioning: the package is introduced at 1.0.0b1, but azure-mgmt-domainservices already has a published stable 1.0.0 on PyPI. Per PEP 440, 1.0.0b1 sorts before 1.0.0, so the release pipeline will reject it as a regression. A major bump (e.g. 2.0.0b1) is expected for a breaking TypeSpec migration, consistent with sibling migrations (azure-mgmt-signalr → 2.0.0b3, azure-mgmt-storagesync → 2.0.0b2).
Changes:
- Adds a TypeSpec-generated
azure-mgmt-domainservicespackage (clientDomainServicesMgmtClient, API2025-10-01-preview). - Adds packaging/build config, README, LICENSE, CI pipeline, and
tsp-location.yaml. - Adds generated recorded-test scaffolding (skipped by default).
Reviewed changes
Copilot reviewed 57 out of 58 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/domainservices/ci.yml | Standard generated CI pipeline for the service directory; correct artifact name/safeName. |
| sdk/domainservices/azure-mgmt-domainservices/tsp-location.yaml | Points to the TypeSpec spec directory and commit for regeneration. |
| sdk/domainservices/azure-mgmt-domainservices/README.md | Getting-started doc; auth snippet matches the client signature. |
| sdk/domainservices/azure-mgmt-domainservices/pyproject.toml | Beta packaging config; is_stable=false, Beta classifier, title matches client name — all correct. |
| sdk/domainservices/azure-mgmt-domainservices/MANIFEST.in | Standard packaging manifest. |
| sdk/domainservices/azure-mgmt-domainservices/LICENSE | Standard MIT license text. |
| sdk/domainservices/azure-mgmt-domainservices/CHANGELOG.md | Declares 1.0.0b1 — a version regression vs. the published 1.0.0; flagged. |
| sdk/domainservices/.../azure/mgmt/domainservices/_version.py | VERSION = "1.0.0b1"; must be bumped in sync with the CHANGELOG. |
| sdk/domainservices/.../generated_tests/*.py | Generated, skipped recorded-test scaffolding (out of MGMT review scope). |
Configurations: 'specification/domainservices/resource-manager/Microsoft.AAD/DomainServices/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '88976ab9ea9fb7f69533fbd465540060bd1f225a' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6528511 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Namespace review issue: https://github.com/Azure/azure-sdk-pr/issues/2646
Other language has released this SDK before so python need to release it to keep consistent across languages.