Auto-hold: DesktopOnly/Everywhere modes + per-player VR opt-out#917
Merged
dooly123 merged 1 commit intoJul 2, 2026
Conversation
CompuGeniusCode
force-pushed
the
feat/vr-autohold
branch
from
b14a214 to
ec69338
Compare
Contributor
Author
|
Closes #908 |
CompuGeniusCode
changed the title
CompuGeniusCode
force-pushed
the
feat/vr-autohold
branch
from
ec69338 to
e6ff18b
Compare
CompuGeniusCode
changed the base branch from
developer
to
working-on-pickups-and-cilbox-allows
CompuGeniusCode
force-pushed
the
feat/vr-autohold
branch
from
e6ff18b to
b54d4f7
Compare
…d intentional re-grab Replace BasisAutoHold Yes/No with None/DesktopOnly/Everywhere: a world can auto-hold on desktop only or everywhere. IsAutoHoldActive() resolves per-device, and VR players can opt out for themselves via the new Disable VR Auto-Hold setting, overriding a world's per-grabbable value. Direct grab now requires a fresh grip press rather than a held grip, so a pickup dropped by the world (or by the auto-hold toggle) stays dropped until the player intentionally grabs again. CueGrip updated to the new enum names.
dooly123
merged commit 3904421
into
BasisVR:working-on-pickups-and-cilbox-allows
9 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Builds on this branch's VR auto-hold. Replaces
BasisAutoHoldYes/NowithNone/DesktopOnly/Everywhere, so a world can auto-hold on desktop only or everywhere.IsAutoHoldActive()now resolves per-device.Opt-out: New
DisableVRAutoHoldplayer setting ("Disable VR Auto-Hold") makesIsAutoHoldActive()return false in VR, overriding a world's per-grabbable value — the player wins over the world. Desktop is unaffected.Drop persistence: Direct grab now requires a fresh grip press instead of a merely-held grip, so a pickup dropped by the world (or by the auto-hold toggle) stays dropped until the player intentionally grabs again — the still-held grip no longer instantly re-grabs it. Reuses the existing
wasGripDownedge.Compat:
DesktopOnly=0(oldYes),None=1(oldNo),Everywhere=2;CueGripupdated to the new names.