Release 1.6.1#396
Merged
Merged
Conversation
The abandon listener intentionally calls `consumer.accept(null)` to signal an abandoned conversation, but the six `Consumer<Boolean>` callsites auto-unboxed the value with `if (value)`, throwing NPE on every inactivity timeout (e.g. when an admin clicks a library entry multiple times before answering). Use `Boolean.TRUE.equals(value)` so abandons are treated as no-ops, and bump to 1.6.1. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cuts the 1.6.1 release. Bundles everything on
developsince the lastmastercut (1.5.3), including the latest hotfix.Latest hotfix (1.6.1):
Consumer<Boolean>callsites now useBoolean.TRUE.equals(value)so abandons are no-ops instead of throwing.Highlights since 1.5.3:
&-codes to MiniMessageisEmpty(), dedup'd string constants, etc.)Test plan
mvn clean verifypasses locally/padmin challengesopens cleanlyconfirm-> import succeeds; click an entry and let it time out -> no NPE in console/[gm] challengeslists imported challenges in the matching gamemode🤖 Generated with Claude Code