Fix betweenness bug#37
Merged
Merged
Conversation
… Overhauled config.py and added functions to functions.py
mszell
approved these changes
Jun 24, 2026
mszell
left a comment
mszell
left a comment
Member
There was a problem hiding this comment.
Looks good, thx! I will make a PR for a new version 0.7.0, I think that's definitely "deserved".
| g.edges[edge]["pbi"] = 1 | ||
| elif g.edges[edge].get("highway") in config.highway_bike_infra: | ||
| g.edges[edge]["pbi"] = 1 | ||
| else: |
Member
There was a problem hiding this comment.
"cyclestreet" does not seem to be considered here. It's so tiny that it doesn't matter for now, but I'll make an issue. Same with "["highway""path"]["bicycle""designated"]", which is included in gbn but not here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes bug for clustered edges. Also set maxgap to 1000 meters, showing better real live results than before. Data export also includes existing bike network.
Related Issue
#33
Fixes #(issue number)
#33
Type of Change
How Has This Been Tested?
Test configuration:
Screenshots (if applicable)
Checklist
Additional Notes