Add NvmeInfo (NVMe SSD health) to SystemPerformanceInfo#275
Merged
Conversation
Add an NvmeInfo message (NVMe SSD health, wear, thermal throttling and identity) and nest it in SystemPerformanceInfo (field 14). Jetson-only; i.MX drones have no NVMe device and leave it at defaults. Partition used/free is reported separately via DataStorageSpaceTel, so NvmeInfo carries only NVMe-specific state plus the physical drive capacity. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an NvmeInfo protobuf message and wires it into SystemPerformanceInfo to expose NVMe SSD SMART/health, throttling, workload, and identity telemetry (Jetson-only; i.MX remains default/empty).
Changes:
- Introduced new
NvmeInfomessage with SMART/health + identify-controller derived fields. - Added
SystemPerformanceInfo.nvme(field 14) to carry the new NVMe telemetry.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Drop the _c suffix (units stay in the comment, consistent with the other temperature fields) and add NVMe to the SystemPerformanceInfo summary. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
johannesschrimpf
approved these changes
Jun 29, 2026
Message presence (has_nvme()) already signals whether NVMe data is available, so the explicit present field is redundant -- remove it and renumber 1..25 (not merged yet, so no wire-compat concern). Also drop the composite-temperature trustworthiness note; it's an SSD-specific implementation detail. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
NvmeInfomessage and nests it inSystemPerformanceInfo(field 14) to expose NVMe SSD state — health/safety, thermal throttling, endurance/workload, and drive identity.Jetson-only: i.MX drones boot/store on an SD card and have no NVMe device, so the message stays at its defaults there. Only the composite temperature is exposed (per-sensor values are vendor-specific and can be stuck placeholders). Partition used/free is already reported via
DataStorageSpaceTel, soNvmeInfocarries only NVMe-specific state plus the physical drivecapacity_bytes.Addresses BluEye-Robotics/p2_drone#982.
Downstream
🤖 Generated with Claude Code