Skip to content

Add Charts2 Storybook samples#9

Open
xrendan wants to merge 4 commits into
masterfrom
codex/charts2-storybook-samples
Open

Add Charts2 Storybook samples#9
xrendan wants to merge 4 commits into
masterfrom
codex/charts2-storybook-samples

Conversation

@xrendan

@xrendan xrendan commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary

  • add the Charts2 package and include its stories in the root Storybook config
  • add CLI-ready sample chart definitions for the supported chart families
  • render the actual embedded Build Canada square / Canada Spends SVG logos in top-right chart chrome
  • size the logo to the rendered height of the title plus subtitle block
  • keep chart title and subtitle rendering in Söhne Kräftig, with SVG markup coverage
  • add descending x-axis tick marks, dashed y-axis spacing gridlines, dashed vertical value markers without duplicate bottom stubs, and production-style Grapher palettes
  • add sample, axis, chrome, theme, SceneSVG, and corpus coverage for these visual defaults

Verification

  • bun test src/core/layout/axis.test.ts
  • bun test src/core/layout/axis.test.ts src/core/layout/chrome.test.ts src/react/SceneSVG.test.tsx src/core/theme/themes.test.ts src/samples.test.ts
  • bun test src/corpus/corpus.test.ts
  • bun run typecheck
  • bun src/cli/index.ts render samples/line-provincial-budgets.json --out -

Note: earlier, bun test src/cli/render.test.ts was run; the existing PNG rasterization smoke test timed out after 5s, while the rest of that file passed.

@xrendan xrendan force-pushed the codex/charts2-storybook-samples branch 3 times, most recently from df66fa9 to 253a8b9 Compare June 12, 2026 16:03
@xrendan xrendan force-pushed the codex/charts2-storybook-samples branch from 253a8b9 to 8af4421 Compare June 12, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant