MOST notebook#334
Conversation
bsipocz
left a comment
There was a problem hiding this comment.
The char.add complain with numpy 1.24 seems to be legitime, here is the traceback. The other failure should be fixed with the suggestion (though I'm puzzled how/why it's passing for the rest of the jobs)
---------------------------------------------------------------------------
UFuncTypeError Traceback (most recent call last)
Cell In[1], line 8
5 ordered_metadata.sort(['mjd_obs','band'])
7 #Construct the image IDs to relate rows to those in the results table
----> 8 ordered_metadata['Image_ID'] = np.char.add(np.char.add(ordered_metadata['scan_id']+'_',
9 np.array(ordered_metadata['frame_num'],dtype='str')+'_'),
10 np.array(ordered_metadata['band'],dtype='str'))
12 #Duplicate results table and index by image ID
13 indexed_results = most_output['results']
UFuncTypeError: ufunc 'add' did not contain a loop with signature matching types (dtype('<U6'), dtype('<U1')) -> None
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
|
@bsipocz I think this should run correctly now, but let me know if there is anything else I should tweak/fix. |
troyraen
left a comment
There was a problem hiding this comment.
Thanks @jonesmg! Will you update the author list to include only the individuals who directly contributed to the notebook? I think that's probably you, Tim, and maybe Brigitta, but you'll know best. Our (relatively new) guidelines are here: How to Contribute a New Notebook: Author List.
Other than that, I think it's ready to go!
I ran this on Fornax and it went well, though I did run into a timeout error on hdul = fits.open(img_access_url). When we run into this repeatedly, we typically handle it by increasing astropy's timeout limit. I suggested the code below. AFAIK, this is the first time we've hit a timeout in this notebook, so you don't necessarily need to increase the limit now.
Co-authored-by: Troy Raen <raen@ipac.caltech.edu>
Co-authored-by: Troy Raen <raen@ipac.caltech.edu>
troyraen
left a comment
There was a problem hiding this comment.
Thanks @jonesmg! Merging now. Then I'll do a quick follow-up PR to standardize some minor formatting and finish the deployment. It should show up here a little later today: https://caltech-ipac.github.io/irsa-tutorials/techniques/
I added the new MOST notebook and included it in the toc.yml.
I decided to put this under the techniques and tools section as MOST can be used with various dataset, even though the tutorial is mostly WISE-based.