Skip to content

MOST notebook#334

Merged
troyraen merged 11 commits into
Caltech-IPAC:mainfrom
jonesmg:main
Jun 25, 2026
Merged

MOST notebook#334
troyraen merged 11 commits into
Caltech-IPAC:mainfrom
jonesmg:main

Conversation

@jonesmg

@jonesmg jonesmg commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

I added the new MOST notebook and included it in the toc.yml.

I decided to put this under the techniques and tools section as MOST can be used with various dataset, even though the tutorial is mostly WISE-based.

@bsipocz bsipocz added the content Content related issues/PRs. label Jun 11, 2026

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The char.add complain with numpy 1.24 seems to be legitime, here is the traceback. The other failure should be fixed with the suggestion (though I'm puzzled how/why it's passing for the rest of the jobs)



---------------------------------------------------------------------------
UFuncTypeError                            Traceback (most recent call last)
Cell In[1], line 8
      5 ordered_metadata.sort(['mjd_obs','band'])
      7 #Construct the image IDs to relate rows to those in the results table
----> 8 ordered_metadata['Image_ID'] = np.char.add(np.char.add(ordered_metadata['scan_id']+'_',
      9                                                        np.array(ordered_metadata['frame_num'],dtype='str')+'_'),
     10                                            np.array(ordered_metadata['band'],dtype='str'))
     12 #Duplicate results table and index by image ID
     13 indexed_results = most_output['results']

UFuncTypeError: ufunc 'add' did not contain a loop with signature matching types (dtype('<U6'), dtype('<U1')) -> None

Comment thread tutorials/techniques-and-tools/MOST_queries.md Outdated
Comment thread tutorials/techniques-and-tools/MOST_queries.md Outdated
jonesmg and others added 4 commits June 16, 2026 10:22
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
@jonesmg

jonesmg commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@bsipocz I think this should run correctly now, but let me know if there is anything else I should tweak/fix.

Comment thread tutorials/techniques-and-tools/MOST_queries.md Outdated
@jonesmg

jonesmg commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

@bsipocz @troyraen Looks like I finally managed to thread the needle and it passes the tests.

@troyraen troyraen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonesmg! Will you update the author list to include only the individuals who directly contributed to the notebook? I think that's probably you, Tim, and maybe Brigitta, but you'll know best. Our (relatively new) guidelines are here: How to Contribute a New Notebook: Author List.

Other than that, I think it's ready to go!

I ran this on Fornax and it went well, though I did run into a timeout error on hdul = fits.open(img_access_url). When we run into this repeatedly, we typically handle it by increasing astropy's timeout limit. I suggested the code below. AFAIK, this is the first time we've hit a timeout in this notebook, so you don't necessarily need to increase the limit now.

Comment thread tutorials/techniques-and-tools/MOST_queries.md
Comment thread tutorials/techniques-and-tools/MOST_queries.md
jonesmg and others added 3 commits June 25, 2026 09:58
Co-authored-by: Troy Raen <raen@ipac.caltech.edu>
Co-authored-by: Troy Raen <raen@ipac.caltech.edu>

@troyraen troyraen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonesmg! Merging now. Then I'll do a quick follow-up PR to standardize some minor formatting and finish the deployment. It should show up here a little later today: https://caltech-ipac.github.io/irsa-tutorials/techniques/

@troyraen troyraen merged commit 8a22246 into Caltech-IPAC:main Jun 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Content related issues/PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants