-
-
Notifications
You must be signed in to change notification settings - Fork 498
London | 26 ITP May | Sayeed Hussain | Sprint 2 | Wireframe #1315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
57a3d25
bb05687
b3a00d9
941f7b9
cc36c30
1adba02
b2712c2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,62 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Wireframe</h1> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css"> | ||
| </head> | ||
|
|
||
| <body> | ||
| <header class="header"> | ||
| <h1>Wireframe</h1> | ||
| <p> | ||
| This page explains the fundamental concepts of git branches,readme files and wireframe. | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img | ||
| src="/Wireframe/Featured_Image_Wireframes_Save_Time_Money.png" | ||
| alt=""> | ||
| <h2>Wireframe</h2> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| Wireframe is the skeleton of a web page. It represents visual layout which helps developer and other team | ||
| members to make a decisions about the product. | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| </article> | ||
| </main> | ||
| <footer> | ||
| <a href="https://www.figma.com/resource-library/what-is-wireframing/">Read more</a> | ||
| </article> | ||
|
|
||
| <article> | ||
| <img src="/Wireframe/1_mtsk3fQ_BRemFidhkel3dA.webp" alt=""> | ||
| <h2>Branch in Git </h2> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| Branch in git is a separate version of main branch used to develop ,edit and test changes before merging into | ||
| the main branch | ||
| </p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
| <a href="https://www.w3schools.com/git/git_branch.asp">Read more</a> | ||
| </article> | ||
|
|
||
| <article> | ||
| <img | ||
| src="/Wireframe/hq720.jpg" | ||
| alt=""> | ||
| <h2>Readme File </h2> | ||
| <p> | ||
| Readme file provides important information about the project such as its purpose ,setup instruction,feature and | ||
| usage. | ||
| </p> | ||
| <a href="https://www.geeksforgeeks.org/git/what-is-readme-md-file/">Read more</a> | ||
| </article> | ||
|
|
||
|
|
||
| </main> | ||
| <footer> | ||
| <p> | ||
| This is the default and practice wireframe. | ||
| </p> | ||
| </footer> | ||
| </body> | ||
|
|
||
| </html> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,11 +30,15 @@ body { | |
| background: var(--paper); | ||
| color: var(--ink); | ||
| font: var(--font); | ||
| margin: 0px; | ||
| } | ||
| a { | ||
| padding: var(--space); | ||
| border: var(--line); | ||
| max-width: fit-content; | ||
| background-color: rgb(242, 238, 238); | ||
| color: black; | ||
| border-radius: 2px; | ||
| } | ||
| img, | ||
| svg { | ||
|
|
@@ -45,15 +49,37 @@ svg { | |
| Setting the overall rules for page regions | ||
| https://www.w3.org/WAI/tutorials/page-structure/regions/ | ||
| */ | ||
|
|
||
|
|
||
| /* This is a header */ | ||
| .header{ | ||
| text-align: center; | ||
|
|
||
| width: 1240px; | ||
| margin-left: 109px; | ||
| margin-bottom: -16px; | ||
| padding: 20px; | ||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
||
| main { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| } | ||
| footer { | ||
|
|
||
| position: fixed; | ||
| bottom: 0; | ||
| bottom: 0px; | ||
| text-align: center; | ||
| margin-right: 20px; | ||
| border-top: 2px solid; | ||
| width: 1515px; | ||
| margin-top: 200px; | ||
| } | ||
|
Comment on lines
+76
to
80
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indentation is off. As a best practice, consider following this guide to enable VS Code's Please note that code formatters may not work correctly when the source code contains syntax errors. If formatting is not working in VS Code, check your code for syntax errors and resolve them before running the formatter again. |
||
|
|
||
|
|
||
| /* ====== Articles Grid Layout ==== | ||
| Setting the rules for how articles are placed in the main element. | ||
| Inspect this in Devtools and click the "grid" button in the Elements view | ||
|
|
@@ -68,6 +94,7 @@ main { | |
| > *:first-child { | ||
| grid-column: span 2; | ||
| } | ||
| margin-bottom: 80px; | ||
| } | ||
| /* ====== Article Layout ====== | ||
| Setting the rules for how elements are placed in the article. | ||
|
|
@@ -76,7 +103,7 @@ Keeping things orderly and separate is the key to good, simple CSS. | |
| */ | ||
| article { | ||
| border: var(--line); | ||
| padding-bottom: var(--space); | ||
| padding-bottom: 20px; | ||
| text-align: left; | ||
| display: grid; | ||
| grid-template-columns: var(--space) 1fr var(--space); | ||
|
|
@@ -87,3 +114,7 @@ article { | |
| grid-column: span 3; | ||
| } | ||
| } | ||
|
|
||
| h2{ | ||
| margin-bottom: 0px; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images
fail to load, giving users essential context about the content or function of the image.
Can you give a more descriptive alt value to all images?