feat(rendering): display tuning on staff lines#2742
Conversation
|
Good job. Seeing the overall code I just have some small performance concern as we additionally loop all staves and tracks to compute things. It would feel a lot cleaner if we would encapsulate the staff-tuning display into a glyph and wire it like this:
I think this mostly a mechanical refactoring, functionally things can mostly stay as they are (just the duplicated checks will vanish as they are all wired into the glyph creation phase). I'm happy if you attempt this refactoring, otherwise I can also take it from here 😉 |
|
@Danielku15 thanks for the feedback! I've addressed your comment - I hope it looks better now. If you see any other things to improve then feel free to commit to this branch. |
|
Thanks for your contribution. Made a small fix in the order of track name, tuning and brackets, added GP8 reading/exporting support and added some more tests. With this the feature is complete. 🥳 |
Issues
#2446
Proposed changes
Activation:
Activation in alphaTex:
Padding is configurable:
Checklist
Further details