feat: sonarscanner-dotnet#182
Open
aahmed-dfe wants to merge 7 commits into
Open
Conversation
12 tasks
nomankhans21
reviewed
Jun 9, 2026
| /o:"${{ inputs.sonarcloud-organisation }}" \ | ||
| /k:"${{ inputs.sonarcloud-project-key }}" \ | ||
| /d:sonar.host.url="${{ inputs.sonarcloud-url }}" \ | ||
| /d:sonar.token="${{ inputs.sonarcloud-token }}" \ |
There was a problem hiding this comment.
Worth checking if we can add ::add-mask:: for the token as a precaution, consistent with how other actions in this repo handle secrets e.g. fix-airbyte-lsn.
Author
There was a problem hiding this comment.
@nomankhans21 thanks - applied feedback.
I've also tested this in a consumer https://github.com/DFE-Digital/get-information-about-pupils/actions/runs/27014377030/job/80368374795
Author
There was a problem hiding this comment.
It might be worth documenting recommended patterns in a CODING_STANDARDS or equivalent for future actions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Introduce a reusable GitHub composite action for running SonarCloud analysis on .NET applications.
This replaces the need for each repository to configure SonarScanner setup, SDK handling, Java setup, and begin/build/end wrapping individually.
As EducationProviderRegistry has 3 repositories that will use Sonar, this seemed a good time to do this. We have a working example on GetInformationAboutPupils.
There are many dotnet projects that consume the cli scanner in
DFE-DigitalChanges proposed in this pull request
Guidance to review
Example consumer on GIAP
After merging
[] Adopt across other projects
[] Java17 deprecation warning from July 26...
Checklist
DevopslabelI have attached the pull request to the trello card