Skip to content

Fix #5923: To be deleted bitstreams should be highlighted#5924

Open
tinsch wants to merge 1 commit into
DSpace:mainfrom
tinsch:fix-bitstream-highlighting
Open

Fix #5923: To be deleted bitstreams should be highlighted#5924
tinsch wants to merge 1 commit into
DSpace:mainfrom
tinsch:fix-bitstream-highlighting

Conversation

@tinsch

@tinsch tinsch commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

References

Description

This PR adds red highlighting to bitstreams marked for deletion, so the user sees clearly which bitstreams they have selected.

Instructions for Reviewers

I reviewed the PR #5880 and encountered the bug this PR here adresses. The solution for both problems seem to be the same. The issue seems to stem from a bootstrap bug (not sure though, could also be a bug we introduced in our code somehow), so we need to add an explicit extra coloring to tr.table-danger rows.

List of changes in this PR:
Introduce a css rule to add an explicit red coloring to tr.table-danger children.

  1. Login as administrator
  2. Go to an item -> Administer Item -> Bitstreams tab
  3. Mark one or more bitstreams for deletion and notice that they are all highlighted in red.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tinsch

tinsch commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

The tests completed without errors on my repo, how can I run them again?

@tdonohue

tdonohue commented Jul 1, 2026

Copy link
Copy Markdown
Member

@tinsch : Unfortunately, per limits of GitHub, only people with Admin-level permissions in GitHub can trigger a test re-run within a PR.

But, I see that was already done for this PR & the tests all passed after a second run.

If you notice this sort of thing in the future, just add a comment asking for a test re-run to be triggered, and someone will take care of it.

@tdonohue

tdonohue commented Jul 1, 2026

Copy link
Copy Markdown
Member

@bram-maegerman : I see the fixes in this PR are the same idea as your fixes in #5880 (just applied to a different part of DSpace). If you'd be willing to quickly test or review this PR, it'd help us to get this merged quickly.

@tdonohue tdonohue added improvement component: administrative tools Related to the admin menu or tools 1 APPROVAL pull request only requires a single approval to merge ux User Experience related works port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release labels Jul 1, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge component: administrative tools Related to the admin menu or tools improvement port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release ux User Experience related works

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

To be deleted bitstreams are not highlighted in administer view

2 participants