DS theme docs practical guidance#186
Open
zoharma wants to merge 8 commits into
Open
Conversation
Contributor
zoharma
commented
May 26, 2026
zoharma
commented
- Added a new doc "Practical Guidance"
- Added new references to it in overview and nav
- fix `borders` to `border` - Made `subtle` the imrpmpotu default for `border` token - Updated `.main and `.emphasis` to `.emphasis` and `border.strong` respectively - Added inline comments
- Introduced top-level 'Overview' and order of pages - Updated `Introduction` to be `Installation` and updated top and bottom (left mid as is for now) - Updated preview with new links
- Added a new doc - Added new references to it in overview and nav
zoharma
changed the title
zoharma
changed the title
zoharma
changed the title
Collaborator
VictoriaBeilsten-Edmands
left a comment
VictoriaBeilsten-Edmands
left a comment
There was a problem hiding this comment.
The practical guidance looks very good. I've added a few comments on making some parts slightly more understandable particularly for people that might not be familiar with some of the terminology.
+ other fixed and rename
zoharma
force-pushed
the
zma/ds-theme-docs-practical-guidance
branch
from
a2299fd to
d223472
Compare
- Introduced top-level 'Overview' and order of pages - Updated `Introduction` to be `Installation` and updated top and bottom (left mid as is for now) - Updated preview with new links + Updated based on comments
- Introduced top-level 'Overview' and order of pages - Updated `Introduction` to be `Installation` and updated top and bottom (left mid as is for now) - Updated preview with new links
….com/DiamondLightSource/sci-react-ui into zma/ds-theme-docs-practical-guidance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.