Created guidance for buttons and updated and added stories#193
Open
zoharma wants to merge 11 commits into
Open
Created guidance for buttons and updated and added stories#193zoharma wants to merge 11 commits into
zoharma wants to merge 11 commits into
Conversation
- Introduced top-level 'Overview' and order of pages - Updated `Introduction` to be `Installation` and updated top and bottom (left mid as is for now) - Updated preview with new links + Updated based on comments
Collaborator
VictoriaBeilsten-Edmands
left a comment
VictoriaBeilsten-Edmands
left a comment
There was a problem hiding this comment.
The content looks good. There is the same issue in dark mode on the .mdx page.
| buttons rather than two contained buttons. | ||
| </p> | ||
|
|
||
| <Canvas of={ButtonStories.RunningWithActiveAlternativeMode} /> |
Collaborator
There was a problem hiding this comment.
The text suggests these should both be outlined
Comment on lines
+338
to
+340
| <Canvas of={ButtonStories.DestructiveAction} /> | ||
|
|
||
| <Canvas of={ButtonStories.ConfirmedDestructiveAction} /> |
Collaborator
There was a problem hiding this comment.
Are these examples of what not to do?
* Refine DiamondDS table surfaces and hierarchy - Remove default elevation from table containers - Add semantic surface styling to table containers - Differentiate table headers using surface-container - Updated to use `tableCell` and added application for sticky
…es (#197) - Added more classes to the `storybook.css` file - Make the values semi-hard-coded, from the `ds-theme` but only for light mode - Remove reference to local styles in the main doc files (Overview and Installation)
- Add new Practical Guidance document - Add references in Overview and navigation - Incorporate review feedback and updates - Update to rely on `storybook.css`
This is now being ignored and applied only to `ds-docs` class
This is now being ignored and applied only to `ds-docs` class
…mondLightSource/sci-react-ui into zma/ds-theme-sb-css-update
…iamondLightSource/sci-react-ui into zma/ds-theme-docs-comp-buttons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.