DYN-10443 disable AA when no network mode#17138
Conversation
github-actions
Bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10443
|
Attaching the evidence
|
There was a problem hiding this comment.
Pull request overview
Adds a No-Network mode guard in the WPF host (DynamoView) to prevent specific view extensions (Autodesk Assistant and Dynamo MCP View Extension) from being registered/loaded when NoNetworkMode is enabled, logging a message when skipped. Includes a new UI test to validate the behavior.
Changes:
- Introduces a private helper (
DisableExtensionWhenNoNetworkMode) and uses it to skip targeted extensions during both “add/startup” and “loaded” phases. - Adds constants for the targeted extension names.
- Adds an NUnit UI test that starts Dynamo in
NoNetworkModeand validates the skip logic.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs |
Adds the No-Network-mode guard, logging, and integrates it into extension startup and loaded loops. |
test/DynamoCoreWpfTests/DynamoViewNoNetworkModeTests.cs |
Adds a new UI test configuring NoNetworkMode = true and asserting the disable logic. |
edwin-vasquez-ucaldas
changed the title
edwin-vasquez-ucaldas
changed the title
RobertGlobant20
left a comment
RobertGlobant20
left a comment
There was a problem hiding this comment.
LGTM with one comment, did you already test it on Revit?
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…thub.com/DynamoDS/Dynamo into DYN-10443_Disable_AA_When__NoNetworkMode # Conflicts: # src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs
For Revit testing, this tool, https://github.com/johnpierson/DynamoVersionPatcher, has an option to patch Revit 2027 with a zip file of a new Dynamo core. I don't have time today, but maybe I can test tomorrow. |
jasonstratton
left a comment
jasonstratton
left a comment
There was a problem hiding this comment.
Just a few minor changes, but it looks good.
|
Purpose
Adds a guard so that when Dynamo runs in No-Network mode, the Autodesk Assistant and Dynamo MCP View Extension view extensions are skipped at both registration (added) and Loaded time, with a log line explaining the skip. Implementation is a small, well-placed private helper (DisableExtensionWhenNoNetworkMode) called from two existing extension loops, plus one NUnit test.
Declarations
Check these if you believe they are true
Release Notes
Reviewers
@jasonstratton @RobertGlobant20
FYIs
@eamiri @jnealb