fix: correct BlockEntityVersion range for MC 26.2 to fix dependency resolution#263
Open
mjiangmc wants to merge 1 commit into
Open
fix: correct BlockEntityVersion range for MC 26.2 to fix dependency resolution#263mjiangmc wants to merge 1 commit into
mjiangmc wants to merge 1 commit into
Conversation
…esolution Fixed an issue where downstream plugins (such as `LimboAuth`) fail to depend on LimboAPI when running on Minecraft 26.2. This was caused by the `BlockEntityVersion` range being outdated for 26.2. This PR updates the version range to ensure that dependency resolution works correctly for dependent plugins on this Minecraft version.
UserNugget
requested changes
Jun 21, 2026
UserNugget
left a comment
UserNugget
left a comment
Member
There was a problem hiding this comment.
Absolutely forget about BlockEntity implementation, thanks for PR.
| MINECRAFT_1_21_9(EnumSet.of(ProtocolVersion.MINECRAFT_1_21_9)), | ||
| MINECRAFT_1_21_11(EnumSet.of(ProtocolVersion.MINECRAFT_1_21_11)), | ||
| MINECRAFT_26_1(EnumSet.of(ProtocolVersion.MINECRAFT_26_1)); | ||
| MINECRAFT_26_1(EnumSet.range(ProtocolVersion.MINECRAFT_26_1, ProtocolVersion.MAXIMUM_VERSION)); |
Member
There was a problem hiding this comment.
Suggested change
| MINECRAFT_26_1(EnumSet.range(ProtocolVersion.MINECRAFT_26_1, ProtocolVersion.MAXIMUM_VERSION)); | |
| MINECRAFT_26_1(EnumSet.of(ProtocolVersion.MINECRAFT_26_1)), | |
| MINECRAFT_26_2(EnumSet.range(ProtocolVersion.MINECRAFT_26_2, ProtocolVersion.MAXIMUM_VERSION)); |
26.2 removed bed from block entities, so we need to add it as separate version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where downstream plugins (such as
LimboAuth) fail to depend on LimboAPI when running on Minecraft 26.2.This was caused by the
BlockEntityVersionrange being outdated for 26.2. This PR updates the version range to ensure that dependency resolution works correctly for dependent plugins on this Minecraft version.