Skip to content

Add default reference point for map rose ( -Td and -Tm)#9074

Merged
Esteban82 merged 2 commits into
masterfrom
set-optional-map-rose-refpoint
Jun 26, 2026
Merged

Add default reference point for map rose ( -Td and -Tm)#9074
Esteban82 merged 2 commits into
masterfrom
set-optional-map-rose-refpoint

Conversation

@Esteban82

Copy link
Copy Markdown
Member

This PR makes the argument optional for the map rose options (-Td and -Tm).

When omitted, GMT now defaults to jTR (top-right corner inside the map frame) instead of raising a parsing error.

This behavior can be tested with:

gmt basemap -R-50/-40/-20/-18 -JM10c -Bf -Td+f -png test
test

Feedback on the default position is welcome.

@Esteban82 Esteban82 requested review from a team and joa-quim June 26, 2026 13:23
@Esteban82 Esteban82 added enhancement Improving an existing feature add-changelog Add PR to the changelog AI-assisted All (or most) of the code was written by Artificial Intelligence. labels Jun 26, 2026
@Esteban82 Esteban82 requested a review from seisman June 26, 2026 13:30
Comment thread src/gmt_support.c Outdated
Comment thread src/gmt_support.c Outdated
@joa-quim

Copy link
Copy Markdown
Member

Top-Right seems good to me.

@Esteban82

Copy link
Copy Markdown
Member Author

Top-Right seems good to me.

Ok. But I think that in pygmt it is at the bottom left corner by default (link). Is this correct @seisman? Should we use the same default position? Or is it ok to have different positions for GMT and PyGMT?

Co-authored-by: Joaquim <jmfluis@gmail.com>
@joa-quim

Copy link
Copy Markdown
Member

Asked Google and it came out with

The traditional symbol for directions on a map (the compass rose) is typically placed in the upper right corner. Placing it here keeps it out of the way of the main map details while remaining easily visible. If an upper corner is unavailable, it is placed in the lower right or lower left.

I think UR is the best default location.

@Esteban82 Esteban82 requested a review from joa-quim June 26, 2026 21:23
@Esteban82

Copy link
Copy Markdown
Member Author

Fine by me.

@Esteban82 Esteban82 merged commit 3e5eabb into master Jun 26, 2026
9 of 13 checks passed
@Esteban82 Esteban82 deleted the set-optional-map-rose-refpoint branch June 26, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-changelog Add PR to the changelog AI-assisted All (or most) of the code was written by Artificial Intelligence. enhancement Improving an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants