Inline node editor drops r/R keystrokes (data corruption) — fix#147
Merged
Conversation
…orruption)
Two document-level keydown shortcuts ('r'/'R' → refreshTextVisibility; Shift+R →
reinit) fired even while the user was typing in the inline node-title editor,
silently swallowing every r/R character and PERSISTING the corrupted title to the
DB (e.g. "Marketing Roadmap" → "Maketing oadmap"). Guard both handlers to bail
when the event target is an editable field (INPUT/TEXTAREA/contenteditable) — the
same guard the undo shortcut already uses.
Found by the live Cloudflare in-depth audit (verified, root-caused). Verified
live-dev: typing "Marketing Roadmap RRR" into the inline editor now persists
exactly; web typecheck clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two global keydown shortcuts ('r'/'R' refresh, Shift+R reinit) hijacked keystrokes while typing in the inline node-title editor, dropping every r/R and persisting the wrong title to the DB. Guarded both to bail on editable targets. Found + verified by the live in-depth audit; verified live-dev that 'Marketing Roadmap RRR' now persists exactly.
🤖 Generated with Claude Code