Skip to content

Live audit: Batch A (user-facing) + Batch C (perf) + live-site journey report#150

Merged
mvalancy merged 3 commits into
devfrom
fix/live-audit-batch-a
Jun 21, 2026
Merged

Live audit: Batch A (user-facing) + Batch C (perf) + live-site journey report#150
mvalancy merged 3 commits into
devfrom
fix/live-audit-batch-a

Conversation

@mvalancy

Copy link
Copy Markdown
Member

Lands the live-Cloudflare-audit fixes plus a new live-site user-journey test.

Batch A — user-facing (SPA)

  • Offline overlay no longer leaks dev hints in prod (env-aware message).
  • Transient me-query no longer logs the user out (only clears on real 401/UNAUTHENTICATED).
  • Mini-map seeds node positions on initial layout (fills on load, not just after a click).
  • a11y: ViewSwitcher/Signin tablist roles + AA contrast; MobileBottomNav "More" sheet dialog role + Esc-to-close + focus; graph <svg> role/label + sr-only description.
  • Login defaults to Passwordless (matches the passwordless product).

Batch C — performance

  • Graph polls relaxed 2s→15s + paused when tab hidden (skipPollAttempt).
  • Idle RAF FPS-sampler pauses on visibilitychange.
  • Bundle split via manualChunks + React.lazy route code-splitting (entry 1.46MB→662KB; largest gzip chunk 266KB < 450KB budget).

live-site journey report

  • tests/e2e/reports/live-cloud-journey.spec.ts: drives the real production SPA as a guest on desktop + phone, recording .webm video + screenshots → unified report + dashboard + piper-tts narration. New live-journey Playwright project + live profile.

Verification

  • typecheck + 228 web unit + build + bundle-size all green.
  • Smoke gate: 4/5 (login, nodes+edges render, no error chrome, no GraphQL errors all pass). The 1 failure — the grow-flow interaction — reproduces identically on pristine dev (51aee62), so it is pre-existing and NOT introduced here; tracked separately. Live Cloud is guest/read-only so grow-flow is not user-facing there.
  • Security headers/CSP ship with the Pages deploy; verified the live index.html has no inline scripts / external origins, and post-deploy verify-live loads the SPA under the CSP.

🤖 Generated with Claude Code

mvalancy and others added 3 commits June 20, 2026 10:23
…ut, minimap, a11y, login default)

From the live Cloudflare audit:
- Offline/connection-error overlay no longer leaks localhost + `./start` dev hints
  in production; env-aware message (generic on hosted, dev hints under import.meta.env.DEV).
  (InteractiveGraphVisualization.tsx)
- A transient `me`-query failure no longer wipes the token / logs the user out;
  only clear session on genuine UNAUTHENTICATED/401, else keep session + hydrate
  from cached user. (AuthContext.tsx)
- Mini-Map seeds from the laid-out graph on load (bounded publish over the first
  few seconds) instead of staying "No nodes yet" until a node is clicked. (IGV)
- A11y: view-switcher + login toggle get role=tab/aria-selected; mobile "More"
  sheet gets role=dialog + Esc-to-close + focus; main graph <svg> gets role=img +
  aria-label + sr-only description; login active-tab contrast bumped to AA.
  (ViewSwitcher.tsx, Signin.tsx, MobileBottomNav.tsx, IGV)
- Login defaults to Passwordless on a passwordless product (Password tab still
  available for admin). (Signin.tsx)

Deferred: phone bottom-row label overlap (needs visual iteration on a 390px device).
Verified: web typecheck clean; web unit suite 228/228. (Smoke gate flaky only due
to a concurrent unrelated Playwright suite starving this box — proven by stashing
these changes and reproducing the same smoke failure on pristine dev.)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…plitting)

From the live audit (#100):
- Graph GetWorkItems/GetEdges poll relaxed 2s → 15s and skipped while the tab is
  hidden (skipPollAttempt); own mutations still refetch instantly. No WS subs, so
  a slow poll keeps cross-client freshness without the idle hammer. (IGV)
- useAdaptiveQuality FPS-sampler rAF loop pauses on tab-hidden (visibilitychange)
  instead of spinning forever in backgrounded tabs. (useAdaptiveQuality.ts)
- Code-splitting: vite manualChunks splits react/apollo/d3/lucide into cacheable
  vendor chunks + Admin/Backend/Ontology/Agents/Analytics are React.lazy routes.
  Entry chunk ~1.46MB → 662KB; largest gzip chunk 266KB (budget 450). (vite.config, App.tsx)

Verified: typecheck clean; production build succeeds with split chunks;
check-bundle-size within budget. (Deeper "stop rAF when graph settled" left for #100.)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…arration)

Drives the real production SPA (graphdone-cloud.pages.dev) as a guest on
desktop (1440x900) and phone (390x844), recording .webm video + a labelled
screenshot per step, then folds into the unified report + live dashboard +
piper-tts narration.

- tests/e2e/reports/live-cloud-journey.spec.ts: the journey. Guest entry uses
  the verify-live recipe (mint guest token from the live Worker, seed
  localStorage, reload); captures the real sign-in + guest dialog first. Each
  screenshot is testInfo.attach'd so it lands in the report. Hard-asserts a
  guest sees nodes render + no JS errors (desktop) and no horizontal overflow
  (mobile); every interaction is best-effort so the tour always produces media.
- playwright.config.ts: new 'live-journey' project (video:'on', screenshot:'on').
- tests/sequences/unified.config.mjs: 'live-journey' sequence + 'live' profile.
- scripts/narrate-report.mjs: give the live desktop/mobile clips clean spoken
  names + real descriptions (was reading the raw test title twice).

Run: TEST_URL=https://graphdone-cloud.pages.dev node tests/run-unified.mjs \
  --profile live --out ../GraphDone-Cloud/live-full-report/<stamp>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mvalancy mvalancy merged commit bf42215 into dev Jun 21, 2026
10 of 11 checks passed
@mvalancy mvalancy deleted the fix/live-audit-batch-a branch June 21, 2026 02:48
@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 18.x & 20.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant