harden(admin): hard-redirect non-admins from /admin + robust guard test#155
Merged
Conversation
The /admin route is already gated by <RequireRole can={canAccessAdmin}> (redirects
non-admins) and the admin nav entry is hidden for non-admins (Layout +
MobileBottomNav), and the Worker rejects admin ops server-side — verified live:
a guest/USER hitting /admin lands back on / with no admin nav and no admin chrome.
Defense-in-depth: Admin.tsx previously rendered an "Access Denied" shell for
non-admins (dead code behind the route guard). Replace it with a hard
<Navigate to="/" replace /> using the shared canAccessAdmin, so the admin tabs/
chrome can NEVER mount for a non-admin even if the route guard is ever changed.
Also make RequireRole.test robust (explicit cleanup between renders + async
findByText) so the redirect assertions don't race the <Navigate> or bleed DOM
between cases — was green in CI but flaky locally. 6/6 pass; full web unit 228/228.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Admin section is fully locked for non-admins: nav entry hidden, /admin route redirects (RequireRole), Worker denies admin ops server-side. This makes Admin.tsx itself redirect (was a dead 'Access Denied' shell) so admin chrome/tabs can never mount for a non-admin, and hardens the RequireRole redirect test (cleanup + async). Verified live (guest+USER → /admin redirects to /). 6/6 guard tests, 228/228 web unit.
🤖 Generated with Claude Code