App portal/feature/upload url endpoint#494
Open
mehanana wants to merge 5 commits into
Open
Conversation
…od or test bucket
…ack file upload progress for the progress bar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /api/v1/uploads/sign returns a real signed GCS URL. The frontend component can now PUT files directly to GCS.
🎫 Issue #484
🎨 Figma Link :
▶ Changelist:
🧪 Testing:
🎥 Screenshots & Screencasts:
POST response contains a uploadUrl, uploadId, and expiresAt:

PUT a real file to the prev uploadUrl -> 200 response:


In the GCS console:
PUT bad MIME type -> 400 response:

PUT oversize file -> 400 response:

PUT malicious filename -> sanitizer strips the path components and the request succeeds with a safe filename:

Go through frontend & upload file -> 200 response & file in GCS:

