feat(cli): vectors-phase index progress; retire Spinner/emit_vectors; optimize phase#328
Merged
HumanBean17 merged 2 commits intoJun 15, 2026
Merged
Conversation
…ize phase process_*_file emit JCIRAG_PROGRESS kind=vectors (approximate total from app_main pre-walk + throttled per-file ticks); the parent emits the terminal vectors event on cocoindex exit (drives clamp-on-completion). optimize_lance_tables emits kind=optimize in-process (covers both call sites). server.run_refresh_pipeline wires the async drain + renderer. Retire Spinner + emit_vectors_start/_finish. Operator commands render Vectors -> Optimize -> Graph. Co-Authored-By: Claude <noreply@anthropic.com>
_approximate_vectors_total's YAML predicate ("/application" in fn)
was always False for a bare filename, so the pre-walk under-counted
application YAML and the divergence went negative (gap=-4). Use
fn.startswith("application"). Move the vectors tick emission under
the lock to match its comment. Drop a dead type-ignore. Tighten the
divergence test to assert gap==0 on the fixture.
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wires the VECTORS and OPTIMIZE phases and retires the old spinner (PR-3 of INDEX-OUTPUT-REWORK, stacks on PR-2):
java_index_flow_lancedb.pyemitsJCIRAG_PROGRESS kind=vectorsfrom insideprocess_*_file(approximate total from anapp_mainpre-walk + throttled per-file ticks). The PARENT emits the terminal vectors event on cocoindex exit (drives clamp-on-completion).lance_optimize.optimize_lance_tablesemitskind=optimizeIN-PROCESS (covers both call sites; exception-safe).pipeline+server.run_refresh_pipeline(async) wireon_progress; dropSpinner+emit_vectors_*.Vectors -> Optimize -> Graphlist.Stack
Base
feat/index-graph-progress(PR-2). PR-4 stacks above. Implementsplans/active/PLAN-INDEX-OUTPUT-REWORK.md§ PR-3.Ontology / reindex
None (stays 17; pure output/UX; no re-index).
Spinner/emit_vectors_*fully retired (grep zero across the tree).Tests
.venv/bin/python -m pytest tests -v-> 818 passed, 13 skipped.JAVA_CODEBASE_RAG_RUN_HEAVY=1runs the 2 cocoindex flow/divergence tests (pre-walk total = actual processed = 139 on the fixture; divergence 0). New light tests cover clamp, indeterminate, approximate-overstate-then-clamp, parent-emits-terminal, optimize phase, retirement.🤖 Generated with Claude Code