refactor[lru shared cache]: Shared object _resources now lru dict#55
Merged
Conversation
winsomeglint
force-pushed
the
lsummerbell/lru-shared-resources
branch
from
fb4c1f0 to
0c6d7b5
Compare
winsomeglint
force-pushed
the
lsummerbell/lru-shared-resources
branch
from
577f09f to
b863a6c
Compare
ClemDoum
reviewed
Jun 22, 2026
| "temporalio~=1.23", | ||
| "typer>=0.15.4,<0.25.1", | ||
| "tomlkit~=0.14.0", | ||
| "lru-dict>=1.4.1", |
Contributor
There was a problem hiding this comment.
Suggested change
| "lru-dict>=1.4.1", | |
| "lru-dict~=1.4", |
| "typer==0.24.0", | ||
| ] | ||
|
|
||
| [tool.uv.sources] |
Contributor
There was a problem hiding this comment.
This repo is only built for when building the docker image when we don't want to install locally but from PyPi
Contributor
Author
There was a problem hiding this comment.
okay. the tests will error out before we merge and datashare-python is updated.
| "datashare-asr-worker==0.8.14", | ||
| "datashare-extract-worker[base]==0.1.37", | ||
| "datashare-python~=0.8.23", | ||
| "datashare-python~=0.8.25", |
Contributor
There was a problem hiding this comment.
This is bumped automatically by the CI when releasing a new version of datashare-python
|
|
||
| TIKA_METADATA_RESOURCENAME = "tika_metadata_resourcename" | ||
|
|
||
| DEFAULT_SHARED_RESOURCES_SIZE = 2 |
Contributor
There was a problem hiding this comment.
I would disable caching of more that 1 model by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharedobject now stores _resources in anlru-dictLRUdictionary with explicit size limits and eviction callbackscomponent_teardownfunction can be passed toSharedas an eviction callback that will call exit on 'AbstractContextManager` resources