fix(datashare python): pydantic deserialization#56
Open
ClemDoum wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datashare-python's API:activity_defnDescriptions
Addresses #47 and refactor activity definition using temporal's interceptor builtin mechanism rather than chaining decorators.
By default temporal bypasses deserialization using the data converter when task argument length differ from activity function arg length.
This is typically the case when we introduce
def my_activity_fn(arg_1: PydanticBaseModel, *, progress: ProgressRateHandler | None = None)since the progress is injected and not passed as activity argument by the user.This was the source of many failure to deserialize pydantic objects as
BaseModelbut asdictinsteadChanges
datashare-pythonFixed
Changed
activity_defnin favor of temporal interceptor mechanism