Updating parameter estimation examples to current parmest interface.#169
Conversation
|
@ksbeattie @blnicho @sufikaur I am still working on this as a draft, but working to finish this tonight. Not ready for review at this time. Not familiar with IDAES PR preferences, but should I remove the PR completely until it is ready for review? Trying to get this into the release if possible to update the documentation for the current iteration of ParmEst. Thanks! |
|
@sufikaur @ksbeattie @blnicho Thank you @blnicho for giving feedback and direction on changes, and please review when available. Thanks! |
|
@ksbeattie Fixed typos and a few other formatting issues. Please approve testing workflow when available |
|
@ksbeattie Apologies, found issue and corrected. Tests passing locally. Please rerun the workflow when available. |
|
Integration tests being tested in IDAES/idaes-pse#1803 |
blnicho
left a comment
There was a problem hiding this comment.
I found one typo repeated in all the notebooks. I'm going to go ahead and fix it and then I think this is ready to merge.
Co-authored-by: Bethany Nicholson <blnicho@users.noreply.github.com>
|
@ksbeattie @sufikaur I think we should merge this PR first, before #170. |
Title: Updating parameter estimation examples to current parmest interface.
Fixes #{Issue}
{Description}
Since the last update to parameter estimation examples, the parmest interface has been redesigned. This PR aims to update the existing notebooks to align with the new interface using the Experiment class.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
📚 Documentation preview 📚: https://idaes-examples--169.org.readthedocs.build/en/169/