Skip to content

Updating parameter estimation examples to current parmest interface.#169

Merged
sufikaur merged 23 commits into
IDAES:mainfrom
sscini:update-parmest-examples-SSC
Jun 12, 2026
Merged

Updating parameter estimation examples to current parmest interface.#169
sufikaur merged 23 commits into
IDAES:mainfrom
sscini:update-parmest-examples-SSC

Conversation

@sscini

@sscini sscini commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Title: Updating parameter estimation examples to current parmest interface.

Fixes #{Issue}

{Description}
Since the last update to parameter estimation examples, the parmest interface has been redesigned. This PR aims to update the existing notebooks to align with the new interface using the Experiment class.


Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--169.org.readthedocs.build/en/169/

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Jun 10, 2026
@ksbeattie ksbeattie requested a review from sufikaur June 10, 2026 20:47
@sscini

sscini commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@ksbeattie @blnicho @sufikaur
Hello all,

I am still working on this as a draft, but working to finish this tonight. Not ready for review at this time.

Not familiar with IDAES PR preferences, but should I remove the PR completely until it is ready for review? Trying to get this into the release if possible to update the documentation for the current iteration of ParmEst.

Thanks!

@sscini sscini marked this pull request as ready for review June 11, 2026 16:55
@sscini

sscini commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@sufikaur @ksbeattie @blnicho
All files for the three examples using parameter estimation should be updated to new parmest interface.

Thank you @blnicho for giving feedback and direction on changes, and please review when available. Thanks!

@sscini

sscini commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@ksbeattie Fixed typos and a few other formatting issues. Please approve testing workflow when available

@sscini

sscini commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@ksbeattie Apologies, found issue and corrected. Tests passing locally. Please rerun the workflow when available.

@sufikaur

Copy link
Copy Markdown
Contributor

Integration tests being tested in IDAES/idaes-pse#1803

@blnicho blnicho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one typo repeated in all the notebooks. I'm going to go ahead and fix it and then I think this is ready to merge.

Co-authored-by: Bethany Nicholson <blnicho@users.noreply.github.com>
@blnicho

blnicho commented Jun 12, 2026

Copy link
Copy Markdown
Member

@ksbeattie @sufikaur I think we should merge this PR first, before #170.

@sufikaur sufikaur merged commit 355ed1b into IDAES:main Jun 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants