Skip to content

fix(pivotGrid): Set pivot date dimension locale data to avoid performance drops.#17398

Open
skrustev wants to merge 1 commit into
21.2.xfrom
skrastev/fix-pivot-perf-21.2.x
Open

fix(pivotGrid): Set pivot date dimension locale data to avoid performance drops.#17398
skrustev wants to merge 1 commit into
21.2.xfrom
skrastev/fix-pivot-perf-21.2.x

Conversation

@skrustev

@skrustev skrustev commented Jul 8, 2026

Copy link
Copy Markdown
Member

IgniteUI/igniteui-blazor#232

Type of Change (check all that apply):

  • Bug fix
  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation
  • Demos
  • CI/CD
  • Tests
  • Changelog
  • Skills/Agents

Component(s) / Area(s) Affected:

Pivot Grid

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Automated e2e tests

Test Configuration:

  • Angular version:
  • Browser(s):
  • OS:

Screenshots / Recordings

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
  • Accessibility (ARIA, keyboard navigation, focus management) has been verified

@skrustev skrustev requested a review from MayaKirova July 8, 2026 06:33
Copilot AI review requested due to automatic review settings July 8, 2026 06:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR targets Pivot Grid performance degradation by ensuring IgxPivotDateDimension instances receive the grid’s current locale and resource strings, and by passing that locale into month formatting.

Changes:

  • Added setDateDimensionsLocaleData() in IgxPivotGridComponent and invoked it when pivotConfiguration is set and when i18n resources change.
  • Extended IgxPivotDateDimension with an internal locale property and used it in the month memberFunction formatting call.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts Introduces locale/resource propagation to pivot date dimensions and hooks it into configuration + i18n change points.
projects/igniteui-angular/grids/core/src/pivot-grid-dimensions.ts Adds locale to IgxPivotDateDimension and passes it into month formatting.

Comment thread projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts Outdated
@skrustev skrustev force-pushed the skrastev/fix-pivot-perf-21.2.x branch from 9deea03 to a76c422 Compare July 8, 2026 06:41
@dkamburov dkamburov added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid: pivot version: 21.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants