fix(pivotGrid): Set pivot date dimension locale data to avoid performance drops.#17398
Open
skrustev wants to merge 1 commit into
Open
fix(pivotGrid): Set pivot date dimension locale data to avoid performance drops.#17398skrustev wants to merge 1 commit into
skrustev wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets Pivot Grid performance degradation by ensuring IgxPivotDateDimension instances receive the grid’s current locale and resource strings, and by passing that locale into month formatting.
Changes:
- Added
setDateDimensionsLocaleData()inIgxPivotGridComponentand invoked it whenpivotConfigurationis set and when i18n resources change. - Extended
IgxPivotDateDimensionwith an internallocaleproperty and used it in the monthmemberFunctionformatting call.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts | Introduces locale/resource propagation to pivot date dimensions and hooks it into configuration + i18n change points. |
| projects/igniteui-angular/grids/core/src/pivot-grid-dimensions.ts | Adds locale to IgxPivotDateDimension and passes it into month formatting. |
9deea03 to
a76c422
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IgniteUI/igniteui-blazor#232
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Pivot Grid
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)