-
Notifications
You must be signed in to change notification settings - Fork 159
fix(pivotGrid): Set pivot date dimension locale data to avoid performance drops. #17399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
skrustev
wants to merge
1
commit into
22.0.x
Choose a base branch
from
skrastev/fix-pivot-perf-22.0.x
base: 22.0.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -299,6 +299,7 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni | |
| this._pivotConfiguration = value; | ||
| this.emitInitEvents(this._pivotConfiguration); | ||
| this.filteringExpressionsTree = PivotUtil.buildExpressionTree(value); | ||
| this.setDateDimensionsLocaleData(); | ||
| if (!this._init) { | ||
| this.setupColumns(); | ||
| } | ||
|
|
@@ -995,6 +996,7 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni | |
| this.setupColumns(); | ||
| // Bind to onResourceChange after the columns have initialized the first time to avoid premature initialization. | ||
| onResourceChangeHandle(this.destroy$, () => { | ||
| this.setDateDimensionsLocaleData(); | ||
| // Since the columns are kinda static, due to assigning DisplayName on init, they need to be regenerated. | ||
| this.setupColumns(); | ||
| }, this); | ||
|
|
@@ -2487,6 +2489,35 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni | |
|
|
||
| protected trackHorizontalRowGroup = (_index: number, rowGroup: IPivotGridRecord[]) => rowGroup[0]?.dataIndex; | ||
|
|
||
| /** | ||
| * Sets the locale and resourceStrings data based on the grid's properties for all IgxPivotDateDimensions in the config. | ||
| */ | ||
| protected setDateDimensionsLocaleData() { | ||
| const topDimensions = [...this.columnDimensions, ...this.rowDimensions]; | ||
|
skrustev marked this conversation as resolved.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if the issue is applicable to the Probably yes, because it would still go though the memberFunction for it. If so then we should |
||
| for (const dim of topDimensions) { | ||
| let foundDateDim: IgxPivotDateDimension | undefined; | ||
| if (dim instanceof IgxPivotDateDimension) { | ||
| foundDateDim = dim; | ||
| } else if (dim.childLevel) { | ||
| var curChild: IPivotDimension | undefined = dim.childLevel; | ||
| while(curChild) { | ||
| if (curChild instanceof IgxPivotDateDimension) { | ||
| foundDateDim = curChild; | ||
| break; | ||
| } | ||
| curChild = curChild.childLevel; | ||
| } | ||
| } | ||
|
|
||
| if (foundDateDim) { | ||
| foundDateDim.resourceStrings = this.resourceStrings; | ||
| if (this.locale) { | ||
| foundDateDim.locale = this.locale; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @hidden @internal | ||
| */ | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also call this on
pivotConfigurationChange, since someone could potentially add a date dimension runtime via the api. Or toggle it on via the UI/Api.