(ci) Update npm-publish workflow for 1st party actions, permissions and node#1749
Open
turbobobbytraykov wants to merge 1 commit into
Open
(ci) Update npm-publish workflow for 1st party actions, permissions and node#1749turbobobbytraykov wants to merge 1 commit into
turbobobbytraykov wants to merge 1 commit into
Conversation
Updated workflow to use newer action versions and added permissions for id-token and contents.
Member
|
@turbobobbytraykov it'd appear the publish workflow is already updated to actions@6 and node 24 looking at the state in master: igniteui-cli/.github/workflows/npm-publish.yml Lines 15 to 18 in bd0bcea https://github.com/IgniteUI/igniteui-cli/blob/master/.github/workflows/npm-publish.yml Thus the conflicts :) |
damyanpetev
reviewed
Jul 10, 2026
Comment on lines
32
to
33
| - name: Validate MCP package contents | ||
| run: npm run validate:package --workspace=@igniteui/mcp-server -- --expected-version "$VERSION" |
Member
There was a problem hiding this comment.
I believe this is already validated on CI level - i.e. the version is committed content, validated on PR. This might be redundant.
| NPM_TAG=latest | ||
| fi | ||
| echo "NPM_TAG=$NPM_TAG" >> $GITHUB_ENV | ||
| echo "$NPM_TAG" |
Member
There was a problem hiding this comment.
Suggested change
| echo ${NPM_TAG} |
Or echo "${NPM_TAG}" will do too - I think it's still valid.
Just would really prefer a single pattern of interpolating env. variables and we're already accessing ${VERSION} with brackets and run deploy ${NPM_TAG} below, etc :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated workflow to use newer action versions and added permissions for id-token and contents - just like in the master branch
+
updated actions/checkout to v7
+
updated node 20 -> 24
Description
Make sure we are aligned with the current practices that are already applied to the master branch.
Related Issue
N/A
Type of Change
Affected Packages
igniteui-cli(packages/cli)@igniteui/cli-core(packages/core)@igniteui/angular-templates(packages/igx-templates)@igniteui/angular-schematics(packages/ng-schematics)@igniteui/mcp-server(packages/igniteui-mcp)Checklist
npm run test)npm run build)npm run lint)Additional Context
N/A