Skip to content

(ci) Update npm-publish workflow for 1st party actions, permissions and node#1749

Open
turbobobbytraykov wants to merge 1 commit into
masterfrom
btraykov/update-publish-workflow
Open

(ci) Update npm-publish workflow for 1st party actions, permissions and node#1749
turbobobbytraykov wants to merge 1 commit into
masterfrom
btraykov/update-publish-workflow

Conversation

@turbobobbytraykov

Copy link
Copy Markdown
Contributor

Updated workflow to use newer action versions and added permissions for id-token and contents - just like in the master branch
+
updated actions/checkout to v7
+
updated node 20 -> 24

Description

Make sure we are aligned with the current practices that are already applied to the master branch.

Related Issue

N/A

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring / code cleanup
  • [x ] Build / CI configuration change

Affected Packages

  • [x ] igniteui-cli (packages/cli)
  • [x ] @igniteui/cli-core (packages/core)
  • [x ] @igniteui/angular-templates (packages/igx-templates)
  • [x ] @igniteui/angular-schematics (packages/ng-schematics)
  • [x ] @igniteui/mcp-server (packages/igniteui-mcp)

Checklist

  • I have tested my changes locally (npm run test)
  • I have built the project successfully (npm run build)
  • I have run the linter (npm run lint)
  • I have added/updated tests as needed
  • My changes do not introduce new warnings or errors

Additional Context

N/A

Updated workflow to use newer action versions and added permissions for id-token and contents.
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 70.252%. remained the same — btraykov/update-publish-workflow into vNext

@kdinev kdinev changed the base branch from vNext to master July 10, 2026 08:58
@damyanpetev

Copy link
Copy Markdown
Member

@turbobobbytraykov it'd appear the publish workflow is already updated to actions@6 and node 24 looking at the state in master:

- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 24

https://github.com/IgniteUI/igniteui-cli/blob/master/.github/workflows/npm-publish.yml

Thus the conflicts :)

Comment on lines 32 to 33
- name: Validate MCP package contents
run: npm run validate:package --workspace=@igniteui/mcp-server -- --expected-version "$VERSION"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is already validated on CI level - i.e. the version is committed content, validated on PR. This might be redundant.

NPM_TAG=latest
fi
echo "NPM_TAG=$NPM_TAG" >> $GITHUB_ENV
echo "$NPM_TAG"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo ${NPM_TAG}

Or echo "${NPM_TAG}" will do too - I think it's still valid.

Just would really prefer a single pattern of interpolating env. variables and we're already accessing ${VERSION} with brackets and run deploy ${NPM_TAG} below, etc :)

@damyanpetev damyanpetev removed the request for review from rkaraivanov July 10, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants